Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to 0.16 #28

Closed
wants to merge 1 commit into from
Closed

Conversation

kurtharriger
Copy link

Updated most things to work with 0.16.

I'm new to using elm and have never used this library before, but made an attempt to get this working under 0.16.

Many updates seemed trivial, but there didn't appear to be any css for the examples and I'm not very good at css so made no attempt to add any.

The readme notes it was necessary to manually add d3.js library. I've seen other libraries include Native/.js file and import it somewhere so I added the native d3 min library and required license for it.

I did have some difficulty updating Voronoi as the Random generator library appears to changed a bit and although the compiler is happy with they type signatures, I'm getting an error in native js fromRecord method looking for a _ in the js object that doesn't exist but otherwise the record looks fine.

I was more interested in getting core library working so didn't want to spend much time on the examples for now, but I figured I would share the updates here so that when you do want to update it you can start where I left off.

@mgold
Copy link

mgold commented Feb 17, 2016

+1

@seliopou
Copy link
Owner

seliopou commented Jul 8, 2016

As noted in #32, I'm going to skip 0.16 support and go straight to 0.17. Sorry I didn't get to this sooner, but thanks for your contributions all the same.

As a side note, when writing bindings for JavaScript library, it's my practice not to include the source code for the target library. Better to rely on the user's existing static asset pipeline for that.

@seliopou seliopou closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants