Use RegExp instead of micromatch. #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micromatch is more geared towards path matching and that doesn't really play well with e.g. Bitbucket style pull request messages like this example: Pull request semantic-release#323: feature/SMKY-1231 Responsiveness fixes That forward slash breaks the old micromatch based implementation. The side effect here is that `releaseRules` patterns must now be compilable to regular expressions.
|
I left
|
|
Hi, I just merged upstream with my fork so that it should be compatible with it. Please, could this be approved & merged. Currently I need to do some funky s..t with a Python script in our CI/CD to overwrite the analyze-commits file with my version of it to have it build it properly without it dying on Bitbucket PR formatted messages (that we have all the time). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micromatch is more geared towards path matching and that doesn't really play well with e.g. Bitbucket style pull request messages like this example:
That forward slash breaks the old micromatch based implementation. The side effect here is that
releaseRulespatterns must now be compilable to regular expressions.