Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to flag patients as deceased #98

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Allow to flag patients as deceased #98

merged 9 commits into from
Jan 12, 2024

Conversation

xispa
Copy link
Member

@xispa xispa commented Nov 14, 2023

Description of the issue/feature this PR addresses

This Pull Request allows to flag patients as deceased. It also adds a filter button "Deceased" in patients listing, as well a dagger mark next to the fullname.

Current behavior before PR

Is not possible to flag patients as deceased

Desired behavior after PR is merged

Is possible to flag patients as deceased

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa requested a review from ramonski November 14, 2023 17:59
Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor translation change required

default=u"Deceased"),
description=_(
u"description_patient_deceased",
default=u"Select if the patient died"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would fit better:
"Select this option if the patient is deceased"

Copy link
Contributor

@ramonski ramonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change!

@ramonski ramonski merged commit 3102e6f into master Jan 12, 2024
2 checks passed
@ramonski ramonski deleted the deceased branch January 12, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants