fix: download minify.exe

[smnandre]

(missed a .exe here..)

May fix #27

[seb-jean]

It's ok but I have another error when I do php bin/console asset-map:compile.

λ php bin/console asset-map:compile -vvv
Warming the icon cache...
Icon cache warmed.

 // Compiling and writing asset files to public

{"message":"Error thrown while running command \"asset-map:compile -vvv\". Message: \"Minify error 1: \"General error\".\"","context":{"exception":{"class":"Sensiolabs\\MinifyBundle\\Exception\\RuntimeException","message":"Minify error 1: \"General error\".","code":0,"file":"C:\\wamp64\\www\\demo\\vendor\\sensiolabs\\minify-bundle\\src\\Minify.php:42"},"command":"asset-map:compile -vvv","message":"Minify error 1: \"General error\"."},"level":500,"level_name":"CRITICAL","channel":"console","datetime":"2024-12-23T19:18:53.669302+00:00","extra":{}}
19:18:53 CRITICAL  [console] Error thrown while running command "asset-map:compile -vvv". Message: "Minify error 1: "General error"."
[
  "exception" => Sensiolabs\MinifyBundle\Exception\RuntimeException^ {
    #message: "Minify error 1: "General error"."
    #code: 0
    #file: "C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\Minify.php"
    #line: 42
    trace: {
      C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\Minify.php:42 { …}
      C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\AssetMapper\MinifierCompiler.php:66 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapperCompiler.php:40 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:107 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:51 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\CachedMappedAssetFactory.php:43 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:41 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:62 { …}
      C:\wamp64\www\demo\vendor\symfony\stimulus-bundle\src\AssetMapper\ControllersMapGenerator.php:133 { …}
      C:\wamp64\www\demo\vendor\symfony\stimulus-bundle\src\AssetMapper\ControllersMapGenerator.php:46 { …}
      C:\wamp64\www\demo\vendor\symfony\stimulus-bundle\src\AssetMapper\StimulusLoaderJavaScriptCompiler.php:52 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapperCompiler.php:40 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:107 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:51 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\CachedMappedAssetFactory.php:43 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:41 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:47 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Command\AssetMapperCompileCommand.php:109 { …}
      C:\wamp64\www\demo\vendor\symfony\asset-mapper\Command\AssetMapperCompileCommand.php:77 { …}
      C:\wamp64\www\demo\vendor\symfony\console\Command\Command.php:279 { …}
      C:\wamp64\www\demo\vendor\symfony\console\Application.php:1094 { …}
      C:\wamp64\www\demo\vendor\symfony\framework-bundle\Console\Application.php:123 { …}
      C:\wamp64\www\demo\vendor\symfony\console\Application.php:342 { …}
      C:\wamp64\www\demo\vendor\symfony\framework-bundle\Console\Application.php:77 { …}
      C:\wamp64\www\demo\vendor\symfony\console\Application.php:193 { …}
      C:\wamp64\www\demo\vendor\symfony\runtime\Runner\Symfony\ConsoleApplicationRunner.php:49 { …}
      C:\wamp64\www\demo\vendor\autoload_runtime.php:29 { …}
      C:\wamp64\www\demo\bin\console:15 {
        › \r
        › require_once dirname(__DIR__).'/vendor/autoload_runtime.php';\r
        › \r
        arguments: {
          "C:\wamp64\www\demo\vendor\autoload_runtime.php"
        }
      }
    }
  },
  "command" => "asset-map:compile -vvv",
  "message" => "Minify error 1: "General error"."
]
{"message":"Command \"asset-map:compile -vvv\" exited with code \"1\"","context":{"command":"asset-map:compile -vvv","code":1},"level":100,"level_name":"DEBUG","channel":"console","datetime":"2024-12-23T19:18:53.736565+00:00","extra":{}} 19:18:53 DEBUG     [console] Command "asset-map:compile -vvv" exited with code "1"
[
  "command" => "asset-map:compile -vvv",
  "code" => 1
]

In Minify.php line 42:

  [Sensiolabs\MinifyBundle\Exception\RuntimeException]
  Minify error 1: "General error".


Exception trace:
  at C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\Minify.php:42
 Sensiolabs\MinifyBundle\Minify->minify() at C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\AssetMapper\MinifierCompiler.php:66
 Sensiolabs\MinifyBundle\AssetMapper\MinifierCompiler->compile() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapperCompiler.php:40
 Symfony\Component\AssetMapper\AssetMapperCompiler->compile() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:107
 Symfony\Component\AssetMapper\Factory\MappedAssetFactory->compileContent() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:51
 Symfony\Component\AssetMapper\Factory\MappedAssetFactory->createMappedAsset() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\CachedMappedAssetFactory.php:43
 Symfony\Component\AssetMapper\Factory\CachedMappedAssetFactory->createMappedAsset() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:41
 Symfony\Component\AssetMapper\AssetMapper->getAsset() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:62
 Symfony\Component\AssetMapper\AssetMapper->getAssetFromSourcePath() at C:\wamp64\www\demo\vendor\symfony\stimulus-bundle\src\AssetMapper\ControllersMapGenerator.php:133
 Symfony\UX\StimulusBundle\AssetMapper\ControllersMapGenerator->loadUxControllers() at C:\wamp64\www\demo\vendor\symfony\stimulus-bundle\src\AssetMapper\ControllersMapGenerator.php:46
 Symfony\UX\StimulusBundle\AssetMapper\ControllersMapGenerator->getControllersMap() at C:\wamp64\www\demo\vendor\symfony\stimulus-bundle\src\AssetMapper\StimulusLoaderJavaScriptCompiler.php:52
 Symfony\UX\StimulusBundle\AssetMapper\StimulusLoaderJavaScriptCompiler->compile() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapperCompiler.php:40
 Symfony\Component\AssetMapper\AssetMapperCompiler->compile() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:107
 Symfony\Component\AssetMapper\Factory\MappedAssetFactory->compileContent() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\MappedAssetFactory.php:51
 Symfony\Component\AssetMapper\Factory\MappedAssetFactory->createMappedAsset() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Factory\CachedMappedAssetFactory.php:43
 Symfony\Component\AssetMapper\Factory\CachedMappedAssetFactory->createMappedAsset() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:41
 Symfony\Component\AssetMapper\AssetMapper->getAsset() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\AssetMapper.php:47
 Symfony\Component\AssetMapper\AssetMapper->allAssets() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Command\AssetMapperCompileCommand.php:109
 Symfony\Component\AssetMapper\Command\AssetMapperCompileCommand->createManifestAndWriteFiles() at C:\wamp64\www\demo\vendor\symfony\asset-mapper\Command\AssetMapperCompileCommand.php:77
 Symfony\Component\AssetMapper\Command\AssetMapperCompileCommand->execute() at C:\wamp64\www\demo\vendor\symfony\console\Command\Command.php:279
 Symfony\Component\Console\Command\Command->run() at C:\wamp64\www\demo\vendor\symfony\console\Application.php:1094
 Symfony\Component\Console\Application->doRunCommand() at C:\wamp64\www\demo\vendor\symfony\framework-bundle\Console\Application.php:123
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at C:\wamp64\www\demo\vendor\symfony\console\Application.php:342
 Symfony\Component\Console\Application->doRun() at C:\wamp64\www\demo\vendor\symfony\framework-bundle\Console\Application.php:77
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at C:\wamp64\www\demo\vendor\symfony\console\Application.php:193
 Symfony\Component\Console\Application->run() at C:\wamp64\www\demo\vendor\symfony\runtime\Runner\Symfony\ConsoleApplicationRunner.php:49
 Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() at C:\wamp64\www\demo\vendor\autoload_runtime.php:29
 require_once() at C:\wamp64\www\demo\bin\console:15

[smnandre]

Thank you @seb-jean ! Is it the same if you try to compile a single file with minify:asset ?

(minify:asset --help for usage example)

😮‍💨 Not easy to debug... Without windows available i may drop its support for now and release the 1.0 without.. I hope not to, but it's not easy to debug / understand what's happenin :|

[seb-jean]

With minify:asset, I have

In Minify.php line 42:

  [Sensiolabs\MinifyBundle\Exception\RuntimeException]
  Minify error 1: "General error".


Exception trace:
  at C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\Minify.php:42
 Sensiolabs\MinifyBundle\Minify->minify() at C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\Minifier\TraceableMinifier.php:39
 Sensiolabs\MinifyBundle\Minifier\TraceableMinifier->minify() at C:\wamp64\www\demo\vendor\sensiolabs\minify-bundle\src\Command\MinifyAssetCommand.php:109
 Sensiolabs\MinifyBundle\Command\MinifyAssetCommand->execute() at C:\wamp64\www\demo\vendor\symfony\console\Command\Command.php:279
 Symfony\Component\Console\Command\Command->run() at C:\wamp64\www\demo\vendor\symfony\console\Application.php:1094
 Symfony\Component\Console\Application->doRunCommand() at C:\wamp64\www\demo\vendor\symfony\framework-bundle\Console\Application.php:123
 Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at C:\wamp64\www\demo\vendor\symfony\console\Application.php:342
 Symfony\Component\Console\Application->doRun() at C:\wamp64\www\demo\vendor\symfony\framework-bundle\Console\Application.php:77
 Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at C:\wamp64\www\demo\vendor\symfony\console\Application.php:193
 Symfony\Component\Console\Application->run() at C:\wamp64\www\demo\vendor\symfony\runtime\Runner\Symfony\ConsoleApplicationRunner.php:49
 Symfony\Component\Runtime\Runner\Symfony\ConsoleApplicationRunner->run() at C:\wamp64\www\demo\vendor\autoload_runtime.php:29
 require_once() at C:\wamp64\www\demo\bin\console:15

minify:asset [-t|--type TYPE] [--] <input> [<output>]

[smnandre]

Well ... i'll have a deeper look after a little break :|

[seb-jean]

No problem!

[smnandre]

Sorry @seb-jean last time i bother you with this...

I made another attempt (just pushed on this branch) and i hope this is the good one 🤞

Could you by chance try with this PR again.... ?

If this still does not work, you'd be a giant help if you could

• check the minify var directory (ls -la var on unix systems, not sure on windows)
• list the file and see its authorisations (ls -la var/minify)
• see if you can run it by checking the version (./var/minify/minify.exe --version -v)
• run the binary file yourself ?

Thank you 🙏

[seb-jean]

Oh no, you're not bothering me!

Yes, it's good 👌! Well done @smnandre !

[smnandre]

Thank you very very much for your help! 🙇