Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share menu #119

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Add share menu #119

merged 8 commits into from
Dec 19, 2024

Conversation

mantuok
Copy link
Collaborator

@mantuok mantuok commented Dec 11, 2024

Description

Implemented a reusable Share Menu component triggered by the "Share Report" button. The menu includes options such as Email, Facebook, X (Twitter), and Copy Link, with functionality to be added later. It aligns with design specifications, is responsive across screen sizes, and is covered by unit tests using Jest. The component is added to the Component Test Library.

#112

Type of changes

  • Bugfix
  • Chore
  • New Feature

Testing

  • I added automated tests
  • I think tests are unnecessary
Screen.Recording.2024-12-10.at.8.24.43.PM.mov

Copy link
Collaborator

@agennadi agennadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The SVG paths are large - should the icons be separate components, or would that be overkill?

@mantuok
Copy link
Collaborator Author

mantuok commented Dec 19, 2024

Looks great! The SVG paths are large - should the icons be separate components, or would that be overkill?

Yes, I thought it might be better that way. Since it was a bit of an eyesore for you too, I’ve moved the SVGs to separate files and imported them as components.

@mantuok mantuok merged commit 84f6e80 into master Dec 19, 2024
3 checks passed
@mantuok mantuok deleted the add_share_menu branch December 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants