-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added API tests #132
Added API tests #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a comment with a very non urgent question
); | ||
*/ | ||
|
||
insert into addresses (eas_fullid, address, unit_number, address_number, street_name, street_type, parcel_number, block, lot, cnn, longitude, latitude, zip_code, point, supdist, supervisor, supname, nhood, sfdata_as_of, created_timestamp, update_timestamp) values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have both (longitude, latitude), and point? Granted, since this table is probably going to be short-lived, it probably doesn't matter. Just curious
Description
init.sql
: added data for landslide_zones, liquefaction_zones, tsunami_zones, soft_story_properties, addresses.globalID
in the Tsunami model is replaced withglobal_id
to avoid case-sensitive issues.address_data_handler.py
.soft_story_properties_data_handler
andaddress_data_handler
.Resolves #113.
Type of changes
Testing
How to test
Tests can be run manually inside the backend docker container using
docker exec -it datasci-earthquake-backend-1 pytest backend/api/tests
.