Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 214: change logo #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] 214: change logo #216

wants to merge 1 commit into from

Conversation

yjshin229
Copy link
Collaborator

  • modify text
  • modify logo

Logo not in figma or assets folder

@yjshin229
Copy link
Collaborator Author

I had to pod install to make the app running.
This modified the podfile.lock. -> seems like it was updating the yoga's SHA automatically..
does anyone know why?
I didn't update pod or RN.

@francisli
Copy link
Contributor

@yjshin229 hmm, my best guess is that version of the package was replaced in the repository for some reason (i.e. security vulnerability, etc), so when you installed it ended up with a different hash. As long as the app continues to function, I think it should be fine. We'll be wanting to upgrade RN and other dependencies soon anyway...

@francisli
Copy link
Contributor

@yjshin229 looks like Kelsie has updated Figma with a new logo... still waiting on final approval, but if you want to drop it in the app to start, I'd export it at 2x size to include in the project...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Code for San Francisco" text, logo in app to "SF Civic Tech"
2 participants