fix(users): default numeric columns for users with no walks to 0 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a bit confusing: before this commit, the backend users page displays new signups whether they've walked or not, but in cases where they have not walked at all, no numeric value is displayed. Anyway, TL;DR: This commit defaults numeric columns in user rows with no walks to 0, which indicates that the user hasn't walked and makes a bit more sense. Signed-off-by: Kevin Morris <kevr@0cost.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit confusing: before this commit, the backend users page displays new signups whether they've walked or not, but in cases where they have not walked at all, no numeric value is displayed.
Anyway, TL;DR: This commit defaults numeric columns in user rows with no walks to 0, which indicates that the user hasn't walked and makes a bit more sense.
Signed-off-by: Kevin Morris kevr@0cost.org