Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #114, #122] Add checkmark to viewed patient registration form sections #128

Merged
merged 14 commits into from
Oct 10, 2024

Conversation

samau3
Copy link
Contributor

@samau3 samau3 commented Sep 19, 2024

Closes #114, closes #122.

This PR adds a checkmark icon as feedback for the user to see which sections have been viewed/completed and displays the select field options in a more readable format.

  • Utilizes conditional rendering to show a check mark for viewed sections
  • Paired with the form submission feedback, the user can more easily identify which sections need to be reviewed to submit the registration form
  • Converts the enumerated values shown on the form select fields to be in title casing
  • Also resolved bug with being unable to change healthcare choices due to not properly updating input field values

image

@samau3 samau3 marked this pull request as ready for review September 19, 2024 05:16
@samau3 samau3 requested a review from francisli September 19, 2024 05:16
Resolved bug when trying to change prefilled healthcare choices due to improper deletion logic
Removed unnecessary inputValue prop since it was duplicative of searchQuery
@samau3 samau3 changed the title [Closes #114] Add checkmark to viewed patient registration form sections [Closes #114, #122] Add checkmark to viewed patient registration form sections Sep 20, 2024
Copy link
Contributor

@francisli francisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve and merge this in to close #114, although I think we can do more with #122...

@francisli francisli merged commit 03dec8b into dev Oct 10, 2024
1 check passed
@francisli francisli deleted the issue-114 branch October 10, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants