Feature/scale dataset #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored scripts to use shared lib (wip)
slight refractor for better reuse
…gade/support-sfusd into feature/scale-fake-dataset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BeeSeeWhy
reviewed
Dec 11, 2024
There was a problem hiding this comment.
I'm still reviewing this...but here is what I noticed:
•On list view:
These pics do not show for the schools:
- César Chávez Elementary School
-- (when you click on profile: neither picture shows nor header pic) - Civic Center Secondary School
-- (when you click on profile: picture shows, but not header pic) - Garfield Elementary
-- (when you click on profile: neither picture shows nor header pic) - Hilltop+El Camino Alternative Schools
-- (when you click on profile: picture shows, but not header pic) - Jefferson Early Elementary School
-- (when you click on profile: picture shows, but not header pic) - Lawton Alternative School (K-8)
-- (when you click on profile: picture shows, but not header pic) - Miraloma Elementary School
-- (when you click on profile: picture shows, but not header pic) - Woodside Learning Center
-- (when you click on profile: neither picture shows nor header pic)
|
Thanks for checking it out. Unfortunately some of the schools didn't have images or logos on the SFUSD site (which is where I'm getting them). We'll have to track those down manually I think. No bother trying to hunt them all down. We can find them all with a DB query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for deployment. There are critical things missing (listed below). But hopefully seeing the complete list of school in the current interface will give us a better sense of how to scale the UI. The school metrics should be accurate and current with the exception of Free/Reduced Lunch which is fake.
For the newly added schools, their
aboutandbullet pointson the profile page were generated by GPT. GPT was only used for the new schools. The existing HS school profiles were kept if available. Their stats were updated to current, and the Free/Reduced Lunch stat was retained if available, otherwise faked using the stat "% disadvantage" instead.Known issues / limitations
Volunteer Today! > fill out formbutton link is not available for the new schools - not sure where to find these links