Skip to content

Commit

Permalink
Fix issue that doesn't switch profile back to default if an error h…
Browse files Browse the repository at this point in the history
…appens while running `copy-image-from-upstream` command (#135)

* fix: ensure that profile is switched back to default

* docs: update CHANGELOG
  • Loading branch information
rafaelgomesxyz authored Jan 22, 2024
1 parent 8326d1f commit 0d36bff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ Changes since the last non-beta release.

_Please add entries here for your pull requests that are not yet released._

### Fixed

- Fixed issue where cpln profile was not switched back to `default` if an error happened while running `copy-image-from-upstream` command. [PR 135](https://github.com/shakacode/heroku-to-control-plane/pull/135) by [Rafael Gomes](https://github.com/rafaelgomesxyz).

### Added

- Added `--domain` option to `maintenance`, `maintenance:on` and `maintenance:off` commands. [PR 131](https://github.com/shakacode/heroku-to-control-plane/pull/131) by [Rafael Gomes](https://github.com/rafaelgomesxyz).
Expand Down
1 change: 1 addition & 0 deletions lib/command/copy_image_from_upstream.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def call # rubocop:disable Metrics/MethodLength
pull_image_from_upstream
push_image_to_app
ensure
cp.profile_switch("default")
delete_upstream_profile
end

Expand Down

0 comments on commit 0d36bff

Please sign in to comment.