Only use CPLN_ORG and CPLN_APP env vars if allowed #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelgomesxyz
commented
Nov 17, 2023
ahangarha
reviewed
Nov 17, 2023
rafaelgomesxyz
force-pushed
the
org-app-env-var-override
branch
from
20d3abd to
626ef95
Compare
justin808
requested changes
Nov 17, 2023
justin808
requested changes
Nov 25, 2023
rafaelgomesxyz
force-pushed
the
org-app-env-var-override
branch
from
c837226 to
feb6499
Compare
|
@justin808 I've rebased the branch to include only changes necessary for this PR. Let's handle everything else in a separate PR. |
|
@rafaelgomesxyz This PR might have conflicts with #110. We need to be more careful for merging. |
rafaelgomesxyz
force-pushed
the
org-app-env-var-override
branch
from
feb6499 to
bdd5d05
Compare
rafaelgomesxyz
changed the base branch from
main
to
dont-read-config-files-for-some-commands
justin808
changed the base branch from
dont-read-config-files-for-some-commands
to
main
justin808
reviewed
Dec 1, 2023
In this commit, instead of having two config classes, we don't load configuration from file unless the command demand extended configuration.
This reverts commit e9dde02.
rafaelgomesxyz
force-pushed
the
org-app-env-var-override
branch
from
bdd5d05 to
c313696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #110 for now!
Fixes #90