Add generator #116
Merged
Add generator #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahangarha
force-pushed
the
dont-read-config-files-for-some-commands
branch
2 times, most recently
from
efa2865 to
b88f712
Compare
ahangarha
force-pushed
the
add-generator
branch
from
e636d04 to
811ef07
Compare
ahangarha
force-pushed
the
add-generator
branch
from
466cb1a to
93547b0
Compare
ahangarha
changed the base branch from
dont-read-config-files-for-some-commands
to
main
ahangarha
force-pushed
the
add-generator
branch
2 times, most recently
from
c913f4c to
94acc63
Compare
ahangarha
force-pushed
the
add-generator
branch
from
94acc63 to
0170241
Compare
justin808
reviewed
Jan 4, 2024
| @@ -0,0 +1,27 @@ | |||
| FROM ruby:3.1.2 | |||
There was a problem hiding this comment.
Why not ruby version from Gemfile?
@borela is there any way that we can have the ruby version in one spot?
There was a problem hiding this comment.
use new Dockerfile from https://github.com/shakacode/react-webpack-rails-tutorial
justin808
requested changes
Jan 4, 2024
| @@ -0,0 +1,27 @@ | |||
| FROM ruby:3.1.2 | |||
| @@ -0,0 +1,27 @@ | |||
| FROM ruby:3.1.2 | |||
There was a problem hiding this comment.
use new Dockerfile from https://github.com/shakacode/react-webpack-rails-tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainso that PR review becomes easier.Tasks:
controlplane.ymlDockerfiletemplates/gvc.ymltemplates/rails.ymltemplates/postgres.yml--destinationfor custom destination path (defaults to./.controlplane)--forceto force file changeCloses #89