Rename cpl to cpflow #595
Rename cpl to cpflow #595
Conversation
|
|
||
| # Run database migrations (or other release tasks) with latest image, | ||
| # while app is still running on previous image. | ||
| # This is analogous to the release phase. | ||
| cpl runner rails db:migrate -a $APP_NAME --image latest | ||
| cpflow run -a $APP_NAME --image latest -- rails db:migrate |
There was a problem hiding this comment.
Updated according to the gem documentation.
WalkthroughThe update migrates all Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
README.md (2)
10-16: Consider avoiding split infinitives.Style-wise, it’s not ideal to insert an adverb (‘easily’) in the middle of an infinitive construction (‘to deploy’). Try moving the adverb to avoid split infinitives.
- See doc in [./.controlplane/readme.md](./.controlplane/readme.md) for how to easily deploy this app to Control Plane. + See doc in [./.controlplane/readme.md](./.controlplane/readme.md) for how to deploy this app easily to Control Plane.Tools
LanguageTool
[style] ~14-~14: Style-wise, it’s not ideal to insert an adverb (‘easily’) in the middle of an infinitive construction (‘to deploy’). Try moving the adverb to avoid split infinitives.
Context: ....md](./.controlplane/readme.md) for how to easily deploy this app to Control Plane. The instructions lev...(SPLIT_INFINITIVE)
17-17: Format the bare URL as a markdown link.A bare URL is used in the documentation. Formatting it as a markdown link improves readability and adheres to best practices.
- in https://github.com/shakacode/heroku-to-control-plane. + in [this repository](https://github.com/shakacode/heroku-to-control-plane).Tools
Markdownlint
17-17: null
Bare URL used(MD034, no-bare-urls)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .controlplane/controlplane.yml (3 hunks)
- .controlplane/readme.md (6 hunks)
- .github/actions/deploy-to-control-plane/action.yml (3 hunks)
- README.md (1 hunks)
Files skipped from review due to trivial changes (2)
- .controlplane/controlplane.yml
- .controlplane/readme.md
Additional context used
LanguageTool
README.md
[style] ~14-~14: Style-wise, it’s not ideal to insert an adverb (‘easily’) in the middle of an infinitive construction (‘to deploy’). Try moving the adverb to avoid split infinitives.
Context: ....md](./.controlplane/readme.md) for how to easily deploy this app to Control Plane. The instructions lev...(SPLIT_INFINITIVE)
Markdownlint
README.md
17-17: null
Bare URL used(MD034, no-bare-urls)
Additional comments not posted (4)
.github/actions/deploy-to-control-plane/action.yml (4)
30-30: LGTM!The gem installation command has been correctly updated to install
cpflowversion 3.0.1.
37-37: LGTM!The command
cpflow profilehas been correctly updated.
52-56: LGTM!The command
cpflow build-imagehas been correctly updated.
65-70: LGTM!The commands
cpflow runandcpflow deploy-imagehave been correctly updated.
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/actions/deploy-to-control-plane/action.yml (3 hunks)
Additional comments not posted (3)
.github/actions/deploy-to-control-plane/action.yml (3)
52-56: Update tocpflow build-imagecommand.The step name and the command have been updated to use
cpflow. Ensure that all parameters and options used with thecpflowcommand are compatible with the new CLI version.This change aligns with the PR's objectives and appears correctly implemented.
65-65: Correct usage ofcpflow runcommand.The command to run the release script has been updated to use
cpflow. Ensure that the script and its parameters are compatible with the new CLI.This update is consistent with the PR's objectives.
70-70: Final deployment command updated tocpflow.The deployment command has been updated to use
cpflow. Verify that all parameters and the overall workflow are correctly adapted to the new CLI.This change is consistent and aligns with the modernization of the deployment process.
|
|
||
| - name: Set Short SHA | ||
| id: vars | ||
| shell: bash | ||
| run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)" | ||
|
|
||
| - name: cpl profile | ||
| - name: cpflow profile |
There was a problem hiding this comment.
Rename step to cpflow profile.
The step name has been correctly updated to cpflow profile. However, the command inside the step still uses cpln. This needs to be updated to cpflow.
Update the command to use the new CLI:
- cpln profile update default
+ cpflow profile update defaultCommittable suggestion was skipped due to low confidence.
|
@justin808 @Seifeldin7 I upgraded cpflow to v4 and it works as expected. I tested the deployment here I will squash and merge this to master and then update #597 to use the new base |
Summary
cplgem tocpflowascplgem is deprecated and updated some commands.This change is
Summary by CodeRabbit
cpltocpflowin configuration files, documentation, and setup instructions.cpflowtool.cpflowgem version4.0.0.cpflow.