Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ディスクリプターのサイズがリトルエンディアンでエンコードされていたのを修正する #4

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

sile
Copy link
Member

@sile sile commented Dec 6, 2024

Copilot Summary

This pull request includes changes to fix the endianness issue in descriptor encoding and add tests for the encode_tag_and_size and decode_tag_and_size functions. The most important changes include updating the CHANGES.md file to reflect the fix and modifying the encoding function to correct the endianness.

Endianness fix:

  • CHANGES.md: Added an entry to document the fix for the descriptor size encoding issue.
  • src/descriptors.rs: Modified the encode_tag_and_size function to reverse the buffer, changing the encoding from little-endian to big-endian.

Testing:

  • src/descriptors.rs: Added a test module with a test case to verify the encode_tag_and_size and decode_tag_and_size functions.

@sile sile merged commit d4e9fdf into develop Dec 6, 2024
10 checks passed
@sile sile deleted the feature/descriptor-size-encode branch December 6, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant