introduce M1 Mac

[shogo82148]

• GitHub Actions: Introducing the new M1 macOS runner available to open source!: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
• GitHub Actions: macOS 14 (Sonoma) is now available: https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/

Summary by CodeRabbit

• Chores
  • Expanded testing to include macOS 14 in the test matrix.
  • Introduced GitHub Actions workflow for building and uploading Perl binaries on the darwin-arm64 platform.
  • Updated workflow for building on darwin-x64 to specify the correct architecture and key for caching.
  • Modified the build.pl script to dynamically determine the architecture and construct the install directory path accordingly.

[coderabbitai]

Warning

Rate Limit Exceeded

@shogo82148 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 5cab369 and fc464c5.

Walkthrough

The update involves expanding the testing environment to include macOS 14 in the GitHub Actions workflow and introducing architecture-specific build optimizations for Perl binaries on darwin-arm64 platform.

Changes

File	Summary
.github/workflows/test.yml .github/workflows/darwin-x64.yml	Added "macos-14" to OS versions in the matrix Updated workflow for darwin-x64
.github/build-openssl-darwin.sh scripts/darwin/build.pl	Introduce architecture-specific build optimizations

🐇✨
In the matrix wide and vast,
A new OS joins the cast.
macOS 14, fresh and keen,
For bugs and features to be seen.
Perl binaries optimized with care,
Arm64's power, a build to bear.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 273091c and e8d28ff.

Files selected for processing (1)

• .github/workflows/test.yml (1 hunks)

Additional comments: 2

.github/workflows/test.yml (2)

• 103-103: The addition of "macos-14" to the OS matrix in the test-darwin job is a direct implementation of the PR's objective to support the latest macOS version. This change ensures that the CI/CD pipeline can run tests on macOS 14 (Sonoma), leveraging the performance benefits of the M1 chip and maintaining compatibility with the latest macOS developments.
• 100-106: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-156]

Overall, the workflow file is well-structured and follows best practices for GitHub Actions. The addition of "macos-14" is correctly placed within the matrix for the test-darwin job, and the rest of the workflow appears to be unaffected by this change. It's important to ensure that all actions and steps within the test-darwin job are compatible with macOS 14 to avoid potential issues during execution. Additionally, considering the workflow includes jobs for Linux and Windows as well, it's clear that the project aims to maintain broad compatibility across different operating systems and platforms.

[coderabbitai]

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e8d28ff and 5cab369.

Files selected for processing (4)

• .github/build-openssl-darwin.sh (1 hunks)
• .github/workflows/darwin-arm64.yml (1 hunks)
• .github/workflows/darwin-x64.yml (4 hunks)
• scripts/darwin/build.pl (1 hunks)

Additional comments: 7

.github/workflows/darwin-x64.yml (4)

• 1-1: The workflow name change to build on darwin-x64 is appropriate and clearly indicates the target architecture. This change enhances clarity for maintainers and contributors.
• 9-9: The update to reference .github/workflows/darwin-x64.yml in the paths section is correct and ensures that changes to this workflow file trigger the appropriate actions.
• 42-42: Switching the runner to macos-11 is a specific choice that aligns with the need to test on a stable macOS version. However, ensure that this version meets all dependencies and requirements for the project's needs.
• 94-94: The cache key now includes ${{ runner.arch }}, which is a significant improvement for distinguishing caches between different architectures. This change will help in avoiding conflicts and ensuring that the cache is architecture-specific.

.github/workflows/darwin-arm64.yml (3)

• 1-1: The introduction of a separate workflow for darwin-arm64 is a strategic move to support the new M1 macOS runner. This allows for targeted builds and tests on the ARM64 architecture, aligning with the PR's objectives.
• 42-42: Setting the runner to macos-14 for the ARM64 workflow is forward-looking, ensuring compatibility with the latest macOS version. This decision is in line with the PR's goal to stay up-to-date with the latest developments.
• 94-94: Including ${{ runner.arch }} in the cache key for the ARM64 workflow is consistent with the changes made in the x64 workflow. This ensures that caches are properly segregated by architecture, which is crucial for maintaining the integrity of the build process.