-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable shared library and PIC, fixes #1756 #1757
Conversation
WalkthroughThe recent modifications to the build scripts for both Darwin and Linux platforms focus on refining the build process. These enhancements include the exclusion of manual directories from the build, the activation of shared libraries and Position Independent Code (PIC) options, and a fix for a Perl-related configuration issue. This streamlined approach aims to optimize the build environment and address specific setup challenges. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- scripts/darwin/build.pl (1 hunks)
- scripts/linux/build.pl (1 hunks)
Additional comments: 2
scripts/linux/build.pl (1)
- 113-118: Ensure the
-Dcccdlflags=-fPIC
and-Duseshrplib
options are compatible across all targeted Linux distributions and Perl versions. This is critical for ensuring the build process's portability and stability.scripts/darwin/build.pl (1)
- 123-128: Verify the
-Dcccdlflags=-fPIC
and-Duseshrplib
options for compatibility with macOS versions and architectures, especially considering the transition to ARM-based chips. Compatibility is essential for ensuring the build process works seamlessly across different macOS versions and hardware.
Summary by CodeRabbit