Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The macOS 15 image for Actions is now available in public beta. #1952

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

shogo82148
Copy link
Owner

@shogo82148 shogo82148 commented Sep 26, 2024

Summary by CodeRabbit

  • New Features

    • Expanded testing environment to include macOS version 15.
  • Chores

    • Updated GitHub Actions workflow configuration to trigger on changes to the workflow file itself, enhancing testing reliability.

Copy link

coderabbitai bot commented Sep 26, 2024

Walkthrough

The pull request introduces an update to the GitHub Actions workflow configuration by adding a new operating system entry, macos-15, to the existing matrix in the .github/workflows/test.yml file. Additionally, it modifies the pull_request trigger to include the workflow file itself in the paths that will initiate the workflow, ensuring that changes to the workflow trigger tests.

Changes

File Change Summary
.github/workflows/test.yml Added macos-15 to the os matrix; included .github/workflows/test.yml in pull_request trigger paths.

Poem

In the meadow where the code does play,
A new macOS joins the fray today!
With hops and skips, our tests will run,
On version fifteen, oh what fun!
A rabbit's cheer for changes bright,
Let's code and test with pure delight! 🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cbb7ce6 and f698442.

📒 Files selected for processing (1)
  • .github/workflows/test.yml (2 hunks)
🧰 Additional context used
actionlint
.github/workflows/test.yml

105-105: label "macos-15" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🔇 Additional comments not posted (1)
.github/workflows/test.yml (1)

5-5: LGTM: Good addition to trigger paths

Adding .github/workflows/test.yml to the pull_request trigger paths is a good practice. This ensures that the workflow runs when changes are made to the workflow file itself, allowing you to catch potential issues in workflow modifications early in the development process.

@@ -101,6 +102,7 @@ jobs:
fail-fast: false
matrix:
os:
- macos-15
Copy link

@coderabbitai coderabbitai bot Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

macos-15 Runner Currently Unsupported

The macos-15 label is not recognized in the available GitHub-hosted runners, and multiple open issues indicate ongoing challenges and lack of official support. It's recommended to:

  • Remove or make the macos-15 job optional in the workflow to prevent potential failures.
  • Monitor GitHub Actions announcements for official support of macos-15 before re-adding it.
🔗 Analysis chain

Verify the availability and stability of the macos-15 runner

The addition of macos-15 to the os matrix aligns with the PR objective of introducing support for the new macOS 15 image for GitHub Actions. However, please note the following:

  1. The static analysis tool flags macos-15 as an unknown label, which suggests it might not be widely recognized yet.
  2. Since the macOS 15 image is in public beta, there might be stability or compatibility issues.

Consider the following actions:

  1. Verify that macos-15 is the correct label for the macOS 15 beta runner. You may want to check the official GitHub documentation or announcements for the exact label to use.
  2. Add a comment in the workflow file indicating that this is a beta feature, which could help other contributors understand the intent and potential instability.
  3. Consider making the macos-15 job optional or allowing it to fail without failing the entire workflow, at least until it's out of beta.

To ensure the macos-15 runner is available and functioning as expected, you can run the following script:

This script will help verify if macos-15 is officially listed and if there are any known issues or discussions about it.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the availability of the macos-15 runner

# Test: Check if macos-15 is listed in available GitHub-hosted runners
gh api /repos/actions/runner-images/labels | jq -r '.[].name' | grep -i 'macos-15'

# Test: Search for any recent issues or discussions about macos-15
gh search issues 'macos-15 in:title,body repo:actions/runner-images' --json title,url,state,createdAt | jq '.'

Length of output: 5688

🧰 Tools
actionlint

105-105: label "macos-15" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's false-positive of actionlint.
macos-15 is now available.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shogo82148, thanks for the clarification! I've noted that macos-15 is now available and that actionlint may report a false positive in this case.

(つ・ω・)つ★ Curious bunny appreciates the update!


✏️ Learnings added
Learnt from: shogo82148
PR: shogo82148/actions-setup-perl#1952
File: .github/workflows/test.yml:105-105
Timestamp: 2024-09-26T05:58:23.792Z
Learning: `macos-15` is now available as a runner label in GitHub Actions workflows.

Learnt from: shogo82148
PR: shogo82148/actions-setup-perl#1952
File: .github/workflows/test.yml:105-105
Timestamp: 2024-09-26T05:58:23.792Z
Learning: `actionlint` may report a false positive when using `macos-15` as a runner label.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

@shogo82148 shogo82148 merged commit 6b82262 into main Sep 26, 2024
25 checks passed
@shogo82148 shogo82148 deleted the macos-15-is-in-public-beta branch September 26, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant