add windows-2025 to the build matrix #2039
Conversation
WalkthroughThe pull request updates the GitHub Actions workflow configuration in Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml(2 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/test.yml
187-187: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
272-272: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
| - windows-2022 | ||
| - windows-2025 |
There was a problem hiding this comment.
Mixed change: Valid windows-2022 but invalid windows-2025
- ✅ Adding
windows-2022is good as it's a supported runner - ❌
windows-2025is not a supported GitHub-hosted runner
Please update the matrix to keep only the supported runners:
matrix:
os:
- windows-2019
- windows-2022
- - windows-2025📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - windows-2022 | |
| - windows-2025 | |
| - windows-2019 | |
| - windows-2022 |
🧰 Tools
🪛 actionlint (1.7.4)
272-272: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
| @@ -184,6 +184,7 @@ | |||
| os: | |||
| - windows-2019 | |||
| - windows-2022 | |||
| - windows-2025 | |||
There was a problem hiding this comment.
Invalid runner label: windows-2025 is not a supported GitHub-hosted runner
The runner label windows-2025 is not recognized by GitHub Actions. The latest supported Windows runner is windows-2022. Using an unsupported runner will cause the workflow to fail.
Please update the matrix to use only supported runners:
matrix:
os:
- windows-2019
- windows-2022
- - windows-2025For reference, see GitHub's documentation on supported runners.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - windows-2025 | |
| - windows-2019 | |
| - windows-2022 |
🧰 Tools
🪛 actionlint (1.7.4)
187-187: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
💡 Codebase verification
Invalid runner labels detected in workflow configuration
Multiple instances of invalid runner labels found:
windows-2025(no such runner exists)macos-15(no such runner exists)
The following runners are valid and commonly used:
ubuntu-24.04,ubuntu-22.04,ubuntu-20.04macos-14,macos-13windows-2019,windows-2022
Consider replacing:
windows-2025withwindows-latestorwindows-2022macos-15withmacos-latestormacos-14
🔗 Analysis chain
Verify runner compatibility across the workflow
Let's verify the compatibility of all runners used in this workflow.
To maintain workflow stability:
- Always verify runner labels against GitHub's official documentation
- Consider using
windows-latestif you want to automatically use the latest supported Windows runner - Set up automated checks (e.g., actionlint) in your CI to catch invalid runner labels early
Also applies to: 271-272
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any other potentially invalid runners in the workflow
# Search for runner specifications in the workflow
echo "Runner specifications found in the workflow:"
rg -A 1 "runs-on:" .github/workflows/test.yml
# Extract and list all matrix OS values
echo -e "\nMatrix OS values found in the workflow:"
rg -A 5 "matrix:" .github/workflows/test.yml | rg "^\s*-\s*\w+"
Length of output: 858
🧰 Tools
🪛 actionlint (1.7.4)
187-187: label "windows-2025" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
There was a problem hiding this comment.
It's false-positive of actionlint. windows-2025 is recently supported.
https://github.blog/changelog/2024-12-19-windows-server-2025-is-now-in-public-preview/
There was a problem hiding this comment.
@shogo82148 了解しました。actionlint が最新のパブリックプレビューに追随できておらず、false-positive になっているということですね。特に問題ないようであればそのまま続行でよいかと思います。もし今後 actionlint などのツールで警告を抑制したい場合は、actionlint.yaml などの設定ファイルで無視するルールを追加してみてください。ありがとうございます！
✏️ Learnings added
Learnt from: shogo82148
PR: shogo82148/actions-setup-perl#2039
File: .github/workflows/test.yml:187-187
Timestamp: 2024-12-20T15:00:46.972Z
Learning: "windows-2025" is recognized as a newly introduced GitHub-hosted Windows runner (in public preview) as of 2024-12-19.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
https://github.blog/changelog/2024-12-19-windows-server-2025-is-now-in-public-preview/
Summary by CodeRabbit