Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more faster and greater and any rations spectre tileing #2

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

reversi-fun
Copy link

By stopping the retention of the coordinates of the figure, it became possible to draw larger spectre figures faster.

@shrx
Copy link
Owner

shrx commented Feb 5, 2024

Hello @reversi-fun, thank you for your contribution. It will take me a couple of days to review the pull request, but looks good at first glance. Just a couple of suggestions:

  • I would remove the matplotlib code, since you already established that drawsvg provides better performance;
  • I would remove the 6 MB spectre_tile7.3-12.7_5-34649useRef.svg rendering as it will create quite some overhead for subsequent commits.

@reversi-fun
Copy link
Author

reversi-fun commented Feb 5, 2024

Hi @shrx,
These changes will fulfill your suggestion.

  • comment out the matplotlib code( Someone might want to select the display area interactively).
  • remove the 6 MB File, and add 108Kb svg file (spectre tile(7.3, 12.7) 3-ITERATIONS 559-tiles).

spectre.py Outdated Show resolved Hide resolved
@shrx
Copy link
Owner

shrx commented Feb 8, 2024

@reversi-fun let me know when you feel this is ready for review.

@reversi-fun
Copy link
Author

@reversi-fun let me know when you feel this is ready for review.
@shrx It's ready.
I hope review about this issure.
#3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants