Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/migrate to Svelte 5 #60

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

rChaoz
Copy link
Contributor

@rChaoz rChaoz commented Oct 25, 2024

Bump major and migrate library to Svelte 5

Closes #57

@rChaoz rChaoz mentioned this pull request Oct 25, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rChaoz rChaoz force-pushed the feat/support-svelte-5 branch from f62b7a8 to 7d6c027 Compare October 25, 2024 11:43
@rChaoz
Copy link
Contributor Author

rChaoz commented Oct 25, 2024

@sibiraj-s all the requested changes are done I think. I created a new PR to update the v1 docs that should be merged first if you want the v1 docs to have the correct installation command, but you'll have to update the tag also or create a new one

@rChaoz rChaoz requested a review from sibiraj-s October 25, 2024 11:51
@rChaoz rChaoz force-pushed the feat/support-svelte-5 branch from 7d6c027 to 13bdc05 Compare October 25, 2024 11:56
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@sibiraj-s
Copy link
Owner

Thanks @rChaoz will review and try to get this merged today or tomorrow.

@alexbaramilis
Copy link

Any progress on this? I'm in the middle of migrating my codebase to Svelte 5 and this is my only blocker 🙏

@sibiraj-s
Copy link
Owner

Any progress on this? I'm in the middle of migrating my codebase to Svelte 5 and this is my only blocker 🙏

Will get it finished by today for sure. Sorry for the delay.

@sibiraj-s
Copy link
Owner

Thanks @rChaoz . 🎉 I did some cleanup on 88286d9, nothing major just stylistic mostly.

I removed $effect.pre call, I saw some comments those incomplete. Also, onMount accepts an async function now, when async cleanup callback doesn't work. which is not there anyway.

Let me know if I misunderstood that. I can fix it. Please see the commit 88286d9 and let me know if you have anythoughts.

Merging the existing changes now, since people are waiting on this.

@sibiraj-s sibiraj-s merged commit 6490536 into sibiraj-s:master Oct 30, 2024
2 checks passed
@rChaoz
Copy link
Contributor Author

rChaoz commented Oct 30, 2024

Hi! I have just a question and a comment. First, why use

{#if children}
  {@render children()}
{/if children}

over

{@render children?.()}

? To my understanding they are the same.

Second, you should update the latest v1 tag to point to the merge made earlier (with the v1 docs), and the 2.0 README header was lost but I'll make a tiny PR for that.

@sibiraj-s
Copy link
Owner

Hi! I have just a question and a comment. First, why use

No reason, just preference, I like verbose when possible. both are absolutely same.

@rChaoz rChaoz deleted the feat/support-svelte-5 branch October 30, 2024 14:46
Copy link

github-actions bot commented Dec 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 support
3 participants