-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/migrate to Svelte 5 #60
Conversation
f62b7a8
to
7d6c027
Compare
@sibiraj-s all the requested changes are done I think. I created a new PR to update the v1 docs that should be merged first if you want the v1 docs to have the correct installation command, but you'll have to update the tag also or create a new one |
7d6c027
to
13bdc05
Compare
Thanks @rChaoz will review and try to get this merged today or tomorrow. |
Any progress on this? I'm in the middle of migrating my codebase to Svelte 5 and this is my only blocker 🙏 |
Will get it finished by today for sure. Sorry for the delay. |
Thanks @rChaoz . 🎉 I did some cleanup on 88286d9, nothing major just stylistic mostly. I removed Let me know if I misunderstood that. I can fix it. Please see the commit 88286d9 and let me know if you have anythoughts. Merging the existing changes now, since people are waiting on this. |
Hi! I have just a question and a comment. First, why use {#if children}
{@render children()}
{/if children} over {@render children?.()} ? To my understanding they are the same. Second, you should update the latest v1 tag to point to the merge made earlier (with the v1 docs), and the 2.0 README header was lost but I'll make a tiny PR for that. |
No reason, just preference, I like verbose when possible. both are absolutely same. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread. |
Bump major and migrate library to Svelte 5
Closes #57