feat: implement boot asset cache #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
force-pushed
the
feat/cache-generated-assets
branch
from
3e975dd to
7d5b7ee
Compare
smira
force-pushed
the
feat/cache-generated-assets
branch
from
7d5b7ee to
22c67a8
Compare
frezbo
reviewed
Oct 27, 2023
frezbo
approved these changes
Oct 27, 2023
Fixes siderolabs#4 This caches the result of the boot asset build (a call to Talos `imager`) so that we don't rebuild the asset twice. OCI Registry is used as a cache. An internal registry can be used for caching, we don't need to expose it to the world. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
feat/cache-generated-assets
branch
from
22c67a8 to
354baca
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
This caches the result of the boot asset build (a call to Talos
imager) so that we don't rebuild the asset twice.OCI Registry is used as a cache. An internal registry can be used for caching, we don't need to expose it to the world.