fix: fix local artifact output locations when BUILDKIT_MULTI_PLATFORM=1
#458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Nov 6, 2024
utkuozdemir
force-pushed
the
fix-multiplatform-local-output
branch
2 times, most recently
from
1becf29 to
c8d2ffa
Compare
…M=1` Passing `BUILDKIT_MULTI_PLATFORM=1` to buildkit for each build (introduced in 7db4f5e) in `COMMON_ARGS` caused some unwanted changes in the output behavior when we ran a single-platform build: it started to output the files to locations same as to multi-platform format, `<os>_<arch>/<filename>`, instead of just `<filename>`. Fix this by running a small script to move these files to one upper directory after a local build. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
force-pushed
the
fix-multiplatform-local-output
branch
from
c8d2ffa to
1fc767a
Compare
utkuozdemir
changed the title
BUILDKIT_MULTI_PLATFORM=1 only on image buildsBUILDKIT_MULTI_PLATFORM=1
smira
approved these changes
Nov 6, 2024
|
/m |
1 similar comment
|
/m |
utkuozdemir
added a commit
to utkuozdemir/sidero-talos-metal-agent
that referenced
this pull request
Nov 6, 2024
Fix generating checksums thanks to the fix in siderolabs/kres#458. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
added a commit
to utkuozdemir/sidero-talos-metal-agent
that referenced
this pull request
Nov 6, 2024
Fix generating checksums thanks to the fix in siderolabs/kres#458. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
BUILDKIT_MULTI_PLATFORM=1to buildkit for each build (introduced in 7db4f5e) inCOMMON_ARGScaused some unwanted changes in the output behavior when we ran a single-platform build: it started to output the files to locations same as to multi-platform format,<os>_<arch>/<filename>, instead of just<filename>.Fix this by running a small script to move these files to one upper directory after a local build.