feat: allow running in Bun, add to CI #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds feature testing to more default metrics so that Bun (and possibly Deno) work. Ref #570
SimenB
reviewed
Nov 25, 2023
| @@ -6,8 +6,10 @@ let perf_hooks; | |||
| try { | |||
| // eslint-disable-next-line | |||
| perf_hooks = require('perf_hooks'); | |||
| new perf_hooks.PerformanceObserver(); | |||
There was a problem hiding this comment.
we don't need to close this in some way? i.e. https://nodejs.org/api/perf_hooks.html#performanceobserverdisconnect
|
@zbjornson are you looking to complete this PR? I am working on a project in Bun that would likely benefit from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds feature testing to more default metrics so that Bun (and possibly Deno) work. The metrics are all called
node_something_something/shrug.I think this is all that's required, but our tests didn't catch any failures without these changes. Appreciate any beta-testing from the community.
For some reason, the tests are way slower in Bun (80 vs 5 seconds). idk how to use Bun's profiler with jest.evidently only on my WSL2 environmentoven-sh/bun#4708 will obviate these changes.
Fixes #570