Misc stuff #507
Merged
Misc stuff #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syyyr
force-pushed
the
re-add-read-all-fd
branch
3 times, most recently
from
61ecf41 to
d804786
Compare
syyyr
force-pushed
the
re-add-read-all-fd
branch
2 times, most recently
from
ecca942 to
dd66b27
Compare
Turns out it is still used by someone. But not on Windows. This reverts commit 325efa6.
Now we got our own `string` namespace, so it collides with std::string, if you use using namespace std.
syyyr
force-pushed
the
re-add-read-all-fd
branch
from
dd66b27 to
a6d0624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.