Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update dependencies jan 2024 #531

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

hahn-kev
Copy link
Collaborator

Updates to sveltekit 2 (with migrations).

Updates pretty much all our dependencies to their latest versions.

@myieye , the following I didn't update because I think we didn't update due to issues. Could you confirm and document it somewhere? like an issue for the bug or a code comment?

> pnpm outdated
┌─────────────────────────┬─────────┬────────┐
│ Package                 │ Current │ Latest │
├─────────────────────────┼─────────┼────────┤
│ svelte-exmarkdown       │ 3.0.1   │ 3.0.3  │
├─────────────────────────┼─────────┼────────┤
│ @floating-ui/dom        │ 1.5.4   │ 1.6.1  │
├─────────────────────────┼─────────┼────────┤
│ daisyui (dev)           │ 4.4.14  │ 4.6.1  │
├─────────────────────────┼─────────┼────────┤
│ sveltekit-search-params │ 2.0.0   │ 2.1.0  │
└─────────────────────────┴─────────┴────────┘

@hahn-kev hahn-kev requested review from rmunn and myieye January 31, 2024 08:09
Copy link

github-actions bot commented Jan 31, 2024

UI unit Tests

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit aa80577.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 31, 2024

C# Unit Tests

39 tests  ±0   39 ✅ ±0   5s ⏱️ ±0s
 7 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit aa80577. ± Comparison against base commit 9c30d40.

♻️ This comment has been updated with latest results.

@myieye
Copy link
Contributor

myieye commented Feb 1, 2024

I updated the remaining node packages:

  • Added a tiny workaround for the daisyUI bug
  • Stopped superforms from spewing warnings
  • Created an issue for warnings we're now getting (only in dev mode) from our svelte query-params lib due to SK 2.?

Also removed the duplicate playwright task you added and tidied up (?) the one we already had.

Everything seems to be working. Lets see what Playwright has to say 😆.

Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and Playwright tests all passed when I merged this into a copy of my Playwright-on-Node branch.

@hahn-kev hahn-kev self-assigned this Feb 7, 2024
@hahn-kev hahn-kev force-pushed the chore/update-dependencies-jan-2024 branch from aa80577 to 2b071b5 Compare February 7, 2024 03:39
@hahn-kev hahn-kev merged commit 8931626 into develop Feb 7, 2024
3 checks passed
@hahn-kev hahn-kev deleted the chore/update-dependencies-jan-2024 branch July 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants