-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code formatting #18
base: master
Are you sure you want to change the base?
Code formatting #18
Conversation
By including the Google Java format plugin, code check-ins which violate formatting will fail the build. To apply automatic formatting use:
|
@simonwep , are we clear to merge and keep going? Thanks. |
Sorry for the late response, yes this looks really good! Didn't know that there plugins for Java to format code and stuff 😊 (I always used the IDE) Only one thing - I'd actually prefer 4 spaces instead of 2 (regarding overall readability), or what do you think? |
@simonwep my apologies, as I just wrapped up a large project at work taking most of my time. Two space base indentation is generally recommended by Google's Java code style formatting conventions. A lot of projects follow it since it offers good readability in most IDEs. https://google.github.io/styleguide/javaguide.html Let me know if you'd prefer to keep it on 4 spaces and I'll close this PR. Thanks! |
Hey, I totally understand and I'm grateful what you've already done! |
Just thought i'd add, i have never see any Java project using 2 spaces. |
Applies automatic Google Java code formatting conventions to the full source tree.
Not a lot of difference with current formatting except:
Thanks!