CMake version for Qt 6.6.x #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjemens
reviewed
Dec 13, 2023
| ##################################################################### | ||
|
|
||
| qt_internal_add_plugin(QSQLCipherPlugin | ||
| OUTPUT_NAME qsqlitecipher |
There was a problem hiding this comment.
I would prefer the output name to remain qsqlcipher
| qt_feature_module_end(NO_MODULE) | ||
|
|
||
| set(WITH_LTM OFF CACHE BOOL "Build with support for libtommath" FORCE) | ||
| add_subdirectory(3rdparty/libtomcrypt) |
There was a problem hiding this comment.
set(BUILD_SHARED_LIBS OFF CACHE BOOL "Build the libtomcrypt as static library" FORCE)
Keep the plugin files to a minimum. Seems to be working but I am not sure if the BUILD_SHARED_LIBS is not used later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the build config to the qt_base version for the sqlite plugin that uses CMake. Then I also replaced the 3rdparty/libtomcrypt folder with a submodule to the develop branch to get the CMake config files.
Maybe this could be used as a start for the cmake version of the plugin (README needs some work)...