Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gvisor to v0.0.0-20240313225113-67a078058255, fix service #1093

Closed
wants to merge 2 commits into from

Conversation

JackDoan
Copy link
Collaborator

gvisor and the service example didn't build for me on go 1.22, this fixes that.

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Jack Doan <j***@r***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

Copy link

Thanks for the contribution! Before we can merge this, we need @JackDoan to sign the Salesforce Inc. Contributor License Agreement.

@wadey
Copy link
Member

wadey commented Apr 23, 2024

Thanks! I might need to combine these changes with #981 to get the tests to pass for merging. Looking into it now.

(the tests seem to fail with note: module requires Go 1.21)

@wadey
Copy link
Member

wadey commented Apr 23, 2024

merging your branch into #981 (so your branch + go1.22) still seems to be getting some weird failures:

# gvisor.dev/gvisor/pkg/waiter
Error: ../../../go/pkg/mod/gvisor.dev/gvisor@v0.0.0-20240313233432-bcc70e30fc76/pkg/waiter/waiter.go:140:2: undefined: waiterEntry
Error: ../../../go/pkg/mod/gvisor.dev/gvisor@v0.0.0-20240313233432-bcc70e30fc76/pkg/waiter/waiter.go:211:7: undefined: waiterList
FAIL	github.com/slackhq/nebula/examples/go_service [build failed]

@wadey
Copy link
Member

wadey commented Apr 23, 2024

oh I see, Github Actions is still selecting the wrong go version. I thought we had it configured to use the version in go.mod.

The other issue is that we need to do go get gvisor.dev/gvisor@go to get the latest version from the go branch, see their docs.

@wadey
Copy link
Member

wadey commented Apr 24, 2024

I have the tests passing in #981 by merging in your changes and making a few more fixes. I'll make sure to credit you in the merge commit there. Thanks!

@wadey wadey mentioned this pull request Apr 24, 2024
@johnmaguire
Copy link
Collaborator

Closing as superseded by #981. Thank you!

@wadey wadey removed this from the v1.9.0 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants