Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate transparency #127

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Certificate transparency #127

wants to merge 18 commits into from

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Oct 9, 2019

Description

This PR adds alpha support for certificate transparency support in step certificates.

@codecov-io
Copy link

codecov-io commented Oct 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@963fe0f). Click here to learn what that means.
The diff coverage is 82.32%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #127   +/-   ##
=========================================
  Coverage          ?   78.29%           
=========================================
  Files             ?       56           
  Lines             ?     6109           
  Branches          ?        0           
=========================================
  Hits              ?     4783           
  Misses            ?     1075           
  Partials          ?      251
Impacted Files Coverage Δ
authority/provisioners.go 71.42% <ø> (ø)
authority/provisioner/gcp.go 95.34% <ø> (ø)
authority/tls.go 60.66% <ø> (ø)
authority/provisioner/noop.go 88.88% <ø> (ø)
authority/provisioner/provisioner.go 39.16% <ø> (ø)
ca/ca.go 54.85% <ø> (ø)
ca/acmeClient.go 82.58% <ø> (ø)
ca/client.go 67.25% <ø> (ø)
authority/provisioner/aws.go 86.53% <ø> (ø)
authority/provisioner/jwk.go 89.36% <ø> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963fe0f...abd0cf2. Read the comment docs.

@maraino maraino marked this pull request as ready for review October 9, 2019 18:11
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ maraino
✅ dopey
❌ josephvoss
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Merging #127 into master will increase coverage by 1.03%.
The diff coverage is 82.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   77.25%   78.29%   +1.03%     
==========================================
  Files          21       56      +35     
  Lines        1750     6109    +4359     
==========================================
+ Hits         1352     4783    +3431     
- Misses        282     1075     +793     
- Partials      116      251     +135     
Impacted Files Coverage Δ
authority/error.go 16.66% <0.00%> (-16.67%) ⬇️
authority/provisioner/aws.go 86.53% <ø> (ø)
authority/provisioner/azure.go 94.02% <ø> (ø)
authority/provisioner/claims.go 69.04% <ø> (ø)
authority/provisioner/collection.go 82.90% <ø> (ø)
authority/provisioner/duration.go 100.00% <ø> (ø)
authority/provisioner/gcp.go 95.34% <ø> (ø)
authority/provisioner/jwk.go 89.36% <ø> (ø)
authority/provisioner/keystore.go 94.80% <ø> (ø)
authority/provisioner/method.go 100.00% <ø> (ø)
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d7231...abd0cf2. Read the comment docs.

@maraino maraino removed the request for review from dopey February 24, 2021 18:33
@maraino maraino marked this pull request as draft February 24, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants