Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow active revocation on http revoke endpoint #2085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VonRehberg
Copy link

Name of feature: Allow active revocation via http endpoint

Pain or issue this feature alleviates: active revocation was already possible via cli but not via http

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Nov 28, 2024
@hslatman hslatman self-assigned this Dec 3, 2024
@hslatman
Copy link
Member

hslatman commented Dec 12, 2024

Hey @VonRehberg, thank you for the PR.

Can you remove the test at

"error/non-passive not implemented": {
rr: &RevokeRequest{
Serial: "10",
ReasonCode: 8,
Passive: false,
},
err: &errs.Error{Err: errors.New("non-passive revocation not implemented"), Status: http.StatusNotImplemented},
},
?

From the looks of it the change looks OK. It seems to stem from the time we only supported passive revocation, but since then support for active revocation was added by the community. In practice the way that is configured and works does seem to make the Passive boolean obsolete, and it seems to be just informational at the moment. I think there's improvements that can be done, but that would require some more work to feed it through, and doesn't need to be in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants