Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api/render: initial implementation of the package #860

Merged
merged 20 commits into from
Mar 30, 2022
Merged

api/render: initial implementation of the package #860

merged 20 commits into from
Mar 30, 2022

Conversation

azazeal
Copy link
Contributor

@azazeal azazeal commented Mar 18, 2022 •
edited
Loading

This PR introduces the api/render package and refactors the rest of the codebase accordingly.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Mar 18, 2022
@azazeal azazeal changed the base branch from master to panos/api/log March 18, 2022 15:37
@azazeal azazeal force-pushed the panos/api/log branch 2 times, most recently from 29c2696 to 0831f6e Compare March 18, 2022 16:21
Base automatically changed from panos/api/log to master March 22, 2022 12:31
@azazeal azazeal marked this pull request as ready for review March 22, 2022 16:42
@azazeal azazeal requested review from hslatman and maraino March 22, 2022 16:42
maraino
maraino requested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change so we can get rid of a couple of functions.

api/render/render.go Outdated Show resolved Hide resolved
api/render/render.go Outdated Show resolved Hide resolved
@azazeal azazeal marked this pull request as draft March 24, 2022 16:39
@azazeal azazeal force-pushed the panos/api/render branch 2 times, most recently from 881f342 to 955eda2 Compare March 28, 2022 14:29
@azazeal azazeal marked this pull request as ready for review March 28, 2022 15:01
@azazeal azazeal requested a review from maraino March 28, 2022 15:01
maraino
maraino approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment but lgtm

api/render/render.go Outdated Show resolved Hide resolved
@azazeal azazeal requested review from maraino and dopey March 29, 2022 13:52
maraino
maraino approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azazeal azazeal merged commit 00634fb into master Mar 30, 2022
@azazeal azazeal deleted the panos/api/render branch March 30, 2022 08:22
@hslatman hslatman mentioned this pull request May 4, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

@hslatman hslatman Awaiting requested review from hslatman

@dopey dopey Awaiting requested review from dopey

Assignees
No one assigned
Labels
needs triage Waiting for discussion / prioritization by team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azazeal @maraino