CCIP-4058 replace f with fObserve and fSign in RMHome and RMNRemote

[jhweintraub]

Replace RMN Configs f with fObserve in RMNHome and fSign in RMNRemote to be more descriptive and modify all tests as well as update the relevant ones to use the new test naming guide.

[github-actions]

Static analysis results are available

Hey @asoliman92, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

[github-actions]

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (core/scripts) , GolangCI Lint (.) , GolangCI Lint (integration-tests/load) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , test-scripts , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. usdcReader.MessageHashes undefined:[Golang Lint (.)]

Source of Error:

core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go:198:31: usdcReader.MessageHashes undefined (type "github.com/smartcontractkit/chainlink-ccip/pkg/reader".USDCMessageReader has no field or method MessageHashes)
core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go:273:31: usdcReader.MessageHashes undefined (type "github.com/smartcontractkit/chainlink-ccip/pkg/reader".USDCMessageReader has no field or method MessageHashes)

Why: The error occurs because the USDCMessageReader type from the github.com/smartcontractkit/chainlink-ccip/pkg/reader package does not have a field or method named MessageHashes. This indicates a mismatch between the expected and actual structure of the USDCMessageReader type.

Suggested fix: Verify the definition of USDCMessageReader in the github.com/smartcontractkit/chainlink-ccip/pkg/reader package and ensure it includes the MessageHashes field or method. If it does not, update the test code to use the correct field or method that exists in USDCMessageReader.

2. usdcReader.MessageHashes undefined:[Run tests]

Source of Error:

core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go:198:31: usdcReader.MessageHashes undefined (type "github.com/smartcontractkit/chainlink-ccip/pkg/reader".USDCMessageReader has no field or method MessageHashes)
core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go:273:31: usdcReader.MessageHashes undefined (type "github.com/smartcontractkit/chainlink-ccip/pkg/reader".USDCMessageReader has no field or method MessageHashes)

Why: The error occurs because the USDCMessageReader type from the github.com/smartcontractkit/chainlink-ccip/pkg/reader package does not have a field or method named MessageHashes. This indicates a mismatch between the expected and actual structure of the USDCMessageReader type.

Suggested fix: Verify the definition of USDCMessageReader in the github.com/smartcontractkit/chainlink-ccip/pkg/reader package and ensure it includes the MessageHashes field or method. If it does not, update the test code to use the correct field or method that exists in USDCMessageReader.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube