-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAPPL-356] script to generate local ocr3 config #15808
base: develop
Are you sure you want to change the base?
Conversation
1baf1c7
to
8e36002
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
8e36002
to
e2f5408
Compare
e2f5408
to
5670c75
Compare
Quality Gate passedIssues Measures |
} | ||
|
||
func (g *generateLocalOCR3Config) Run(args []string) { | ||
publicKeys := []byte(`[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are there hardcoded values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I assumed that a local setup script would accept some auth params for a set of nodes, query each of the nodes for the necessary key values, then build the pubKeys
slice with the fetched data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. It would be nice to let the values be injected instead of code modifications per case (e.g., an example may be taken from https://github.com/smartcontractkit/chainlink/blob/develop/core/scripts/keystone/src/88_gen_ocr3_config_test.go)
} | ||
|
||
func (g *generateLocalOCR3Config) Run(args []string) { | ||
publicKeys := []byte(`[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. It would be nice to let the values be injected instead of code modifications per case (e.g., an example may be taken from https://github.com/smartcontractkit/chainlink/blob/develop/core/scripts/keystone/src/88_gen_ocr3_config_test.go)
Description
This pr adds a script to generate the OCR3 config for a local env
CAPPL-356
Requires
Supports