Ccip-4110 migration test #15854

AnieeG · 2025-01-07T15:02:40Z

Requires

Supports

…develop

github-actions · 2025-01-07T15:04:03Z

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

github-actions · 2025-01-07T15:16:04Z

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , GolangCI Lint (integration-tests) , Core Tests (go_core_tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , test-scripts , Core Tests (go_core_race_tests) , SonarQube Scan , lint

1. Undefined field `DecodedWorkflowName` in `RequestMetadata` struct: [go_core_race_tests]

Source of Error:

core/capabilities/targets/write_target.go:352:49: request.Metadata.DecodedWorkflowName undefined (type capabilities.RequestMetadata has no field or method DecodedWorkflowName)
core/services/workflows/engine.go:443:4: unknown field DecodedWorkflowName in struct literal of type capabilities.RequestMetadata
core/services/workflows/engine.go:968:4: unknown field DecodedWorkflowName in struct literal of type capabilities.RequestMetadata
core/services/workflows/engine.go:994:4: unknown field DecodedWorkflowName in struct literal of type capabilities.RequestMetadata
core/capabilities/compute/compute.go:303:43: req.Metadata.DecodedWorkflowName undefined (type *"github.com/smartcontractkit/chainlink-common/pkg/workflows/wasm/pb".FetchRequestMetadata has no field or method DecodedWorkflowName)

Why: The RequestMetadata struct does not contain a field or method named DecodedWorkflowName. This indicates that the code is trying to access a field that does not exist in the struct definition.

Suggested fix: Ensure that the RequestMetadata struct definition includes the DecodedWorkflowName field or update the code to use the correct field name that exists in the struct.

2. Unused imports and variables: [deployment]

Source of Error:

ccip/changeset/cs_active_candidate_test.go:4:2: "math/big" imported and not used
ccip/changeset/cs_active_candidate_test.go:20:2: "github.com/smartcontractkit/chainlink/v2/core/logger" imported and not used
ccip/changeset/cs_active_candidate_test.go:28:10: assignment mismatch: 1 variable but NewMemoryEnvironment returns 2 values
ccip/changeset/cs_active_candidate_test.go:136:3: declared and not used: block
ccip/changeset/cs_active_candidate_test.go:190:2: declared and not used: tokenConfig (typecheck)

Why: The code contains unused imports and variables, and there is a mismatch in the number of variables assigned from a function that returns multiple values.

Suggested fix: Remove the unused imports and variables. Ensure that the correct number of variables are assigned from functions that return multiple values.

3. No Go files to analyze: [integration-tests]

Source of Error:

level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"

Why: The Go linter could not find any Go files to analyze in the specified directory. This might be due to missing or misplaced Go files.

Suggested fix: Ensure that the directory contains Go files. Running go mod tidy might help in resolving any module-related issues.

4. No Go files to analyze: [root]

Source of Error:

level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"

Why: Similar to the previous error, the Go linter could not find any Go files to analyze in the root directory.

Suggested fix: Ensure that the root directory contains Go files. Running go mod tidy might help in resolving any module-related issues.

5. Go module updates needed: [generate]

Source of Error:

go: updates to go.mod needed; to update it:
go mod tidy
error: exit status 1
error: integration-tests error: exit status 1

Why: The Go module dependencies are not up-to-date, and the go.mod file needs to be updated.

Suggested fix: Run go mod tidy to update the go.mod file and ensure all dependencies are correctly listed.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

makramkd

💯

makramkd · 2025-01-09T12:54:24Z

core/services/ocr2/plugins/ccip/testhelpers/integration/jobspec.go

@@ -323,7 +323,7 @@ func (params CCIPJobSpecParams) BootstrapJob(contractID string) *OCR2TaskJobSpec
 		},
 	}
 	return &OCR2TaskJobSpec{
-		Name:           fmt.Sprintf("%s-%s", Boostrap, params.DestChainName),
+		Name:           fmt.Sprintf("%s-%s-%s", Boostrap, params.SourceChainName, params.DestChainName),


If we're here fixing stuff may as well fix the typo Boostrap

makramkd · 2025-01-09T12:55:37Z

deployment/ccip/changeset/cs_add_lane_test.go

-		},
-	})
-	require.NoError(t, err)
+	AddLaneWithDefaultPricesAndFeeQuoterConfig(t, &e, state, chain1, chain2, true)


Haha we removed this and now its back, I actually copy/pasted the above code for my PR but I guess having this helper is fine.

makramkd · 2025-01-09T12:56:12Z

deployment/ccip/changeset/cs_chain_contracts.go

+		if cfg.TestRouter {
+			if err := commoncs.ValidateOwnership(e.GetContext(), cfg.MCMS != nil, e.Chains[chainSel].DeployerKey.From, chainState.Timelock.Address(), chainState.TestRouter); err != nil {
+				return err
+			}
+		} else {
+			if err := commoncs.ValidateOwnership(e.GetContext(), cfg.MCMS != nil, e.Chains[chainSel].DeployerKey.From, chainState.Timelock.Address(), chainState.Router); err != nil {
+				return err
+			}
 		}


q: if TestRouter is enabled why not validate ownership of it + the real router? Instead of either/or

The real router can be owned by MCMS and test router can be owned by deployer key.

makramkd · 2025-01-09T12:57:08Z

deployment/ccip/changeset/cs_update_rmn_config_test.go

+				RMNStaticConfig:  NewTestRMNStaticConfig(),
+				NodeOperators:    NewTestNodeOperator(e.Env.Chains[e.HomeChainSel].DeployerKey.From),
+				NodeP2PIDsPerNodeOpAdmin: map[string][][32]byte{
+					"NodeOperator": envNodes.NonBootstraps().PeerIDs(),


Is "NodeOperator" the name of the nop or something? Would be nice as a constant or determined via some other way?

makramkd · 2025-01-09T12:57:51Z

deployment/ccip/changeset/test_environment.go

@@ -233,15 +235,25 @@ func (d *DeployedEnv) SetupJobs(t *testing.T) {

 type MemoryEnvironment struct {
 	DeployedEnv
-	Chains map[uint64]deployment.Chain
+	TCConfig *TestConfigs


naming nit: just TestConfigs?

makramkd · 2025-01-09T12:59:08Z

deployment/ccip/changeset/test_environment.go

+	var err error
+	envNodes, err := deployment.NodeInfo(e.Env.NodeIDs, e.Env.Offchain)


Suggested change

var err error

envNodes, err := deployment.NodeInfo(e.Env.NodeIDs, e.Env.Offchain)

envNodes, err := deployment.NodeInfo(e.Env.NodeIDs, e.Env.Offchain)

makramkd · 2025-01-09T13:02:18Z

integration-tests/smoke/ccip/ccip_migration_to_v_1_6_test.go

+	// Adding to src1 and dest chains first, due to the open issue -
+	// if ccip contracts are added to all chains and only one lane is enabled between src1 and dest, the plugin will not work
+	// until lanes are added involving the rest of the chains


What open issue is this referring to?

…ccip-4110-migration-test

…t/chainlink into ccip-4110-migration-testi

cl-sonarqube-production · 2025-01-09T17:40:18Z

Quality Gate passed

Issues
1 New issue
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.5% Duplication on New Code

See analysis details on SonarQube

AnieeG added 15 commits December 6, 2024 16:47

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

ded3f4c

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

10314c8

…develop

remove deployCCIPContracts

5f14bf0

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

75c676f

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

b31ec5a

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

5f6d2d5

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

65616ff

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

6dd9c4a

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

813cc6e

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

a299e7c

…develop

deprecate existing add lane

1837b21

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

bda53fc

…develop

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

e171316

…develop

new migration test

f8574e7

first version

950caa3

AnieeG requested review from a team as code owners January 7, 2025 15:02

AnieeG requested review from winder, rstout, asoliman92, makramkd, dimkouv, mateusz-sekara and 0xnogo January 7, 2025 15:02

AnieeG marked this pull request as draft January 7, 2025 15:02

more updates

0b75a79

AnieeG added 4 commits January 8, 2025 12:49

fix tests

1216211

more fixes

e45b045

include in pipeline

dfe7a2a

enabling test

f0ecc26

AnieeG marked this pull request as ready for review January 8, 2025 23:51

AnieeG requested review from a team as code owners January 8, 2025 23:51

AnieeG and others added 2 commits January 8, 2025 15:52

merge

d5d1df3

upgrade chainlink ccip fixing router binding issues in migration

843e228

asoliman92 requested a review from a team as a code owner January 9, 2025 11:53

asoliman92 requested a review from EasterTheBunny January 9, 2025 11:53

asoliman92 mentioned this pull request Jan 9, 2025

Allow only price aggregator contract to have multiple bindings [CCIP-4781] smartcontractkit/chainlink-ccip#426

Merged

asoliman92 added 3 commits January 9, 2025 15:59

Merge branch 'develop' into ccip-4110-migration-test

ec2391a

Merge branch 'develop' into ccip-4110-migration-test

810fda5

upgrade chainlink ccip fixing router binding issues in migration

7558959

makramkd reviewed Jan 9, 2025

View reviewed changes

AnieeG added 3 commits January 9, 2025 09:07

Merge branch 'develop' of github.com:smartcontractkit/chainlink into …

7d74ac6

…ccip-4110-migration-test

review comments

06cbc31

Merge branch 'ccip-4110-migration-test' of github.com:smartcontractki…

d9f7594

…t/chainlink into ccip-4110-migration-testi

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ccip-4110 migration test #15854

Ccip-4110 migration test #15854

AnieeG commented Jan 7, 2025

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025 •

edited

Loading

makramkd left a comment

makramkd Jan 9, 2025

makramkd Jan 9, 2025

makramkd Jan 9, 2025

AnieeG Jan 9, 2025

makramkd Jan 9, 2025

makramkd Jan 9, 2025

makramkd Jan 9, 2025

makramkd Jan 9, 2025

cl-sonarqube-production bot commented Jan 9, 2025

		var err error
		envNodes, err := deployment.NodeInfo(e.Env.NodeIDs, e.Env.Offchain)

Ccip-4110 migration test #15854

Are you sure you want to change the base?

Ccip-4110 migration test #15854

Conversation

AnieeG commented Jan 7, 2025

Requires

Supports

github-actions bot commented Jan 7, 2025

github-actions bot commented Jan 7, 2025 • edited Loading

AER Report: CI Core

1. Undefined field DecodedWorkflowName in RequestMetadata struct: [go_core_race_tests]

2. Unused imports and variables: [deployment]

3. No Go files to analyze: [integration-tests]

4. No Go files to analyze: [root]

5. Go module updates needed: [generate]

AER Report: Operator UI CI ran successfully ✅

makramkd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Jan 9, 2025

Quality Gate passed

github-actions bot commented Jan 7, 2025 •

edited

Loading

1. Undefined field `DecodedWorkflowName` in `RequestMetadata` struct: [go_core_race_tests]