-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requestable/Request Item API Endpoints #15922
base: develop
Are you sure you want to change the base?
Conversation
Renamed CheckoutRequest action classes to include "Action" in their names for consistency and clarity. Enhanced error handling in controllers to standardize error responses with translations. Updated usage of the renamed action classes throughout the code to ensure proper integration.
PR Summary
|
Description
This adds actions for creating and cancelling checkout requests, as well as adding new endpoints for the API to bring the functionality there. This should probably not be merged until #15893 is as it relies on the same pattern.
The only real change here I think is that the cancel functionality has been broken out into its own route and action for the GUI, whereas before it was combined into the same controller method. I also renamed the controller methods to keep it CRUD-y.
There are some tests written for the new API functionality, and all other tests are passing.
I wrote this a while ago so I might be forgetting some things, but I wanted to get #15893 open before opening this one, so please ask questions about anything that's unclear. :)
Fixes #SC-24347
Type of change
How Has This Been Tested?
Tests written.
Test Configuration: