Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Form::select and Form::textarea to blade components #15983

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

marcusmoore
Copy link
Collaborator

This PR introduces the <x-input.select> and <x-input.textarea> blade components in place of Form::select and Form::textarea.

More details to come...

Copy link

what-the-diff bot commented Dec 17, 2024

PR Summary

  • New Blade components added

    • A new custom select input (<x-input.select>) and a textarea component (<x-input.textarea>) have been added for repeated usage in various files.
  • Refactoring of selection components

    • The existing selection components throughout various files such as category type, field values, status selections in different scenarios, and fieldset selections have been refactored to the new select component (<x-input.select>).
  • Change in field mapping and import type selections

    • The field mapping and import type selection in importer.blade.php is updated to use the newly introduced select component.
  • Conversion of textarea inputs

    • Several textarea entries (for example, EULA text area in the category edit form, LDAP client TLS key input) have been modified to use the new textarea component (<x-input.textarea>).
  • Update in Slack settings form

    • The webhook selection in the Slack settings form has been modernized to use the new select component (<x-input.select>).
  • Implementing new components in various forms

    • Several forms for status labels, file upload, bulk edit, custom fields, and branding settings have been modified to use the new input components, thus replacing traditional Form facade methods. This change enhances the maintainability of the codebase.
  • File deletions

    • Files related to category, company, location, manufacturer, and supplier have been purged due to redundancy or obsolescence.
  • Refactoring of EULA text area, depreciation method, and label selection in forms

    • The entries in general.blade.php like EULA text area and depreciation method are updated from Form::textarea and Form::select to the new <x-input.textarea> and <x-input.select> components respectively.
  • Improvement in LDAP and SAML input handling

    • LDAP client's TLS key and certificate inputs and SAML's SP certificate, Identity Provider Metadata, and custom settings inputs have been transitioned from Form::textarea to <x-input.textarea> for better maintainability.

Comment on lines +3 to +4
'cols' => 50,
'rows' => 10,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: these are the defaults that Form::textarea would give you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant