SNOW-358605: Let heartbeatAsync return the same result as with select…

… 1 (#535)
snowflakedb · Jun 14, 2023 · 9879949 · 9879949
1 parent 40ef145
commit 9879949
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/connection/connection.js b/lib/connection/connection.js
@@ -136,7 +136,8 @@ function Connection(context)
   {
     return new Promise((resolve, reject) =>
     {
-      this.heartbeat((err, body) => err ? reject(err) : resolve(body));
+      // previous version of driver called `select 1;` which result in `[ { '1': 1 } ]`
+      this.heartbeat((err) => err ? reject(err) : resolve([ { '1': 1 } ]));
     });
   };
 
@@ -151,8 +152,8 @@ function Connection(context)
     }
     try
     {
-      const heartbeatResult = await this.heartbeatAsync()
-      return heartbeatResult.success;
+      await this.heartbeatAsync()
+      return true;
     }
     catch (e)
     {

diff --git a/test/integration/testConnection.js b/test/integration/testConnection.js
@@ -1159,7 +1159,7 @@ describe('Connection Test - Heartbeat', () =>
   it('call heartbeat url as promise', async () =>
   {
     const rows = await connection.heartbeatAsync();
-    assert.ok(rows.success);
+    assert.deepEqual(rows,  [ { '1': 1 } ]);
   });
 });