update_dq improvement in findsat_mrt

[dvstark]

Description

This PR is to add in functionality to acstools.utils_findsat_mrt.updatedq to expand the input mask to match the size of the original DQ array if necessary. This is needed if a satellite trail was identified and masked on a binned image, which is common. Users could do this manually, but it is needed frequently enough that it made sense to include. This step has also been designed to handle images with odd dimensions,(e.g., WFC3/UVIS are 2051x4096) which ensures the code is applicable to other imaging data.

Warnings have been added into acstools.findsat_mrt.TrailFinder.rebin step to inform users if their data has odd dimensions and that rows/columns were being trimmed as needed to allow rebinning (this was happening already, but users may not have been aware). These trimmed rows/columns are added back in during the update_dq step after the satellite mask is enlarged.

[pllim]

Lemme close/reopen and see.

[pllim]

You can ignore the triage failure in this PR. That is my bad.

[dvstark]

just to put all comments in one space: I had asked what the triage step is and what might be causing it to fail

[pllim]

You do have a minimal test in https://github.com/spacetelescope/acstools/blob/master/acstools/tests/test_wfc_findsat_mrt.py . If you can expand your test suite to cover this new option, would prevent regression in the future, but I'll leave that up to you.

[jryon]

I ran a few basic tests with different sizes of masks paired with ACS and WFC3 data. The results look good and make sense, except for the case when the mask is larger than the DQ array.

[dvstark]

I'm unsure what to do about the error in the "Python 3.12 with remote data and dev dependencies" CI test:

py312-test-devdeps: commands[3] /home/runner/work/acstools/acstools/.tmp/py312-test-devdeps> pytest --pyargs acstools /home/runner/work/acstools/acstools/doc --remote-data -v
ImportError while loading conftest '/home/runner/work/acstools/acstools/conftest.py'.
../../conftest.py:10: in <module>
    from acstools.version import version
../../acstools/__init__.py:20: in <module>
    from . import satdet  # noqa
../../acstools/satdet.py:152: in <module>
    import skimage
../../.tox/py312-test-devdeps/lib/python3.12/site-packages/skimage/__init__.py:128: in <module>
    from ._shared import geometry
geometry.pyx:1: in init skimage._shared.geometry
    ???
E   ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
py312-test-devdeps: exit 4 (1.01 seconds) /home/runner/work/acstools/acstools/.tmp/py312-test-devdeps> pytest --pyargs acstools /home/runner/work/acstools/acstools/doc --remote-data -v pid=2518
  py312-test-devdeps: FAIL code 4 (303.45=setup[272.30]+cmd[9.07,20.65,0.42,1.01] seconds)
  evaluation failed :( (303.59 seconds)
Error: Process completed with exit code 4.

Some new issue with skimage and satdet?

[pllim]

You can ignore the devdeps failure for now. Maybe scikit-image nightly wheel needs time to catch up to numpy nightly wheel. With numpy 2.0 in beta now, hopefully soon. I'll give it a few days and up to a week.

[dvstark]

I've done the updates and am ready for this PR to be reviewed again. Thanks for the feedback so far!

[jryon]

Couple more very minor comments

[jryon]

Happy with this!

[dvstark]

@pllim The Wheel-building step is being skipped. Do we need to make sure that passes before merging this in?

[pllim]

Does not hurt. I added the label to enable it.

[pllim]

Since Jenna approved, I have nothing much to add, except one Sphinx formatting fix.

[pllim]

Thanks, all!