Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.rst #203

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Update index.rst #203

merged 2 commits into from
Apr 11, 2024

Conversation

gsanand
Copy link
Contributor

@gsanand gsanand commented Apr 11, 2024

testing citation preview

@github-actions github-actions bot added the docs label Apr 11, 2024
Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I would note it higher up, but link to CITATION.md instead. That way, we do not have to keep track of the same info in two different places.

Also, with Jenna on leave, who will approve this from ACS Team? @dvstark ?

@pllim
Copy link
Collaborator

pllim commented Apr 11, 2024

Also preview is here: https://acstools--203.org.readthedocs.build/en/203/

@dvstark
Copy link
Contributor

dvstark commented Apr 11, 2024

Also, with Jenna on leave, who will approve this from ACS Team? @dvstark ?

I'm happy to fill in for Jenna. But when I look at the readthedocs preview, I don't see any specific link to the acstools citation, just a message that says "please cite acstools if you have used it in your work". Is this expected, or is there a way to put the actual link to the ads page right there in readthedocs?

@dvstark
Copy link
Contributor

dvstark commented Apr 11, 2024

I see from the code Deep edited, the link is there, but it's not showing up in my preview

@dvstark dvstark self-requested a review April 11, 2024 17:14
doc/source/index.rst Outdated Show resolved Hide resolved
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Copy link
Contributor

@dvstark dvstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dvstark dvstark merged commit 4b196bd into spacetelescope:master Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants