Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WFC3 notebook 'TVB_flattenramp_notebook.ipynb' #111

Merged
merged 17 commits into from
Jan 7, 2024

Conversation

dulude
Copy link
Collaborator

@dulude dulude commented Oct 6, 2023

Relevant Tickets


This notebook checklist has been made available to us by the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.

The First Cell

  • The title of the notebook in a first-level heading (eg. <h1> or # in markdown).
  • A brief description of the notebook.
  • A table of contents in an ordered list (1., 2., etc. in Markdown).
  • The author(s) and affiliation(s) (if relevant).
  • The date first published.
  • The date last edited (if relevant).
  • A link to the notebook's source(s) (if relevant).

The Rest of the Cells

  • There is only one H1 (# in Markdown) used in the notebook.
  • The notebook uses other heading tags in order (meaning it does not skip numbers).

Text

  • All link text is descriptive. It tells users where they will be taken if they open the link.
  • All acronyms are defined at least the first time they are used.
  • Field-specific/specialized terms are used when needed, but not excessively.

Code

  • Code sections are introduced and explained before they appear in the notebook. This can be fulfilled with a heading in a prior Markdown cell, a sentence preceding it, or a code comment in the code section.
  • Code has explanatory comments (if relevant). This is most important for long sections of code.
  • If the author has control over the syntax highlighting theme in the notebook, that theme has enough color contrast to be legible.
  • Code and code explanations focus on one task at a time. Unless comparison is the point of the notebook, only one method for completing the task is described at a time.

Images

  • All images (jpg, png, svgs) have an image description. This could be

    • Alt text (an alt property)
    • Empty alt text for decorative images/images meant to be skipped (an alt attribute with no value)
    • Captions
    • If no other options will work, the image is decribed in surrounding paragraphs.
  • Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)

Visualizations

  • All visualizations have an image description. Review the previous section, Images, for more information on how to add it.

  • Visualization descriptions include

    • The type of visualization (like bar chart, scatter plot, etc.)
    • Title
    • Axis labels and range
    • Key or legend
    • An explanation of the visualization's significance to the notebook (like the trend, an outlier in the data, what the author learned from it, etc.)
  • All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.

  • All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.

  • All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.

@dulude dulude added the WFC3 Wide Field Camera 3 label Oct 6, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

update requirements.txt with different version numbers so the notebook works. Also adds crds.
add version number for hstcal (2.7.4)
@kyhuynh108
Copy link
Contributor

@haticekaratay @camipacifici
Hi, this notebook is ready for review, with a couple of additional comments:

  1. I can't seem to fix the pep8 fail i got: the error says it is an indentation error, however that entire cell seems to be formatted correctly. Do you have any ideas on whats causing this fail and what I can do to fix it? I tried to fix it through several different commits without any success. It's also not showing other pep8 fails the notebook may have, but I tried to fix as much as I could manually.
  2. The line "...see the IR IMA Visualization Notebook (O'Connor 2023)." in "Learning Goals" is currently linking to the IR IMA visualization notebook directory in the main hst notebook github repository. Should this be linked to the HQ output site version when this notebook is published?

Thanks,
Ky

@FDauphin
Copy link
Contributor

@haticekaratay @camipacifici Hi, this notebook is ready for review, with a couple of additional comments:

  1. I can't seem to fix the pep8 fail i got: the error says it is an indentation error, however that entire cell seems to be formatted correctly. Do you have any ideas on whats causing this fail and what I can do to fix it? I tried to fix it through several different commits without any success. It's also not showing other pep8 fails the notebook may have, but I tried to fix as much as I could manually.
  2. The line "...see the IR IMA Visualization Notebook (O'Connor 2023)." in "Learning Goals" is currently linking to the IR IMA visualization notebook directory in the main hst notebook github repository. Should this be linked to the HQ output site version when this notebook is published?

Thanks, Ky

Hey @haticekaratay, just a small bump for @kyhuynh108 questions a few weeks ago 👍🏾

@haticekaratay
Copy link
Collaborator

Hi @dulude,
I fixed numerous style errors that weren't listed in the logs while trying to replicate the error mentioned by @kyhuynh108. Is it because v4 is being used in the actions? Can you please take a look? Thanks

@haticekaratay
Copy link
Collaborator

Hi @dulude, I fixed numerous style errors that weren't listed in the logs while trying to replicate the error mentioned by @kyhuynh108. Is it because v4 is being used in the actions? Can you please take a look? Thanks

This issue has been resolved. Thank you @dulude for updating the CI implementation to check Pep8.

Copy link
Collaborator

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work. I made some improvements to the notebook to assist you in the process. Specifically, I :

  • Corrected style errors
  • Refactored the file paths to improve clarity, and implemented context managers for file manipulation
  • Updated the string manipulations to clearer formats

@haticekaratay haticekaratay merged commit 14ec9f5 into main Jan 7, 2024
6 checks passed
@haticekaratay haticekaratay deleted the add_wfc3_tvb_flattenramp_notebook branch January 7, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WFC3 Wide Field Camera 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants