Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-Rejection wrapper for calstis — crrej_from_raw() #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sean-lockwood
Copy link
Member

This code does the following:

  • parse an input RAW STIS file for the CRREJTAB
  • determine the appropriate row from the default CRREJTAB
  • determine user overrides for the various CRREJTAB columns
  • write a temporary CRREJTAB
  • update the input RAW file to use the temporary CRREJTAB and add a HISTORY line
  • run calstis on the RAW file
  • revert the CRREJTAB and HISTORY in the RAW file

Note on testing:
The associated tests only check that input parameters do not fail immediately. The calls to calstis are terminated early by making the test data not contain a data table. So, output FITS products are not tested for the desired changes in the CRREJTAB.

@awfullerton: Let me know if you have any feedback on the interface or the routine name.

@sean-lockwood
Copy link
Member Author

sean-lockwood commented May 15, 2023

@sean-lockwood sean-lockwood changed the title CR-Rejection wrapper for calstis — override_crrej() CR-Rejection wrapper for calstis — crrej_from_raw() May 26, 2023
@sean-lockwood sean-lockwood marked this pull request as ready for review May 26, 2023 18:40
@sean-lockwood sean-lockwood requested a review from a team as a code owner May 26, 2023 18:40
@sean-lockwood
Copy link
Member Author

@stscirij -
I wasn't able to get the test code to work in the tests/ directory on my system, likely due to the conftest.py conflicting with the bare tests generated to test this routine. It does work fine when moved to another location.

Any thoughts on how to get this working properly would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant