inttag: remove sherpagehrels ERR outputs #162
Merged
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrels' upper confidence interval. With a null data array in the ERR extension, CalSTIS will now default to using Gaussian noise statistics. Based on the analysis by Joshua Lothringer (@jlothringer).
jlothringer
approved these changes
Mar 28, 2024
|
Just confirmed no tests touch on the ERR extension. |
|
@stscirij - We've decided to remove them and revert to default Poissonian errors for now. Does the implementation look good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the inttag 2D error extensions calculated using the 'sherpagehrels' upper confidence interval. With a null data array in the ERR extension, CalSTIS will now default to using Gaussian noise statistics.
Based on the analysis by Joshua Lothringer (@jlothringer).
Updated
inttagto v1.1.