Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcloud to 504.0.0 #259

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Update gcloud to 504.0.0 #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Define the google cloud sdk image tag to use.
ARG GOOGLE_CLOUD_CLI_IMAGE_TAG=497.0.0-alpine
ARG GOOGLE_CLOUD_CLI_IMAGE_TAG=504.0.0-alpine

# Build go binaries
FROM golang:1.23.0-alpine3.20 AS gobinaries
FROM golang:1.23.4-alpine3.20 AS gobinaries

# https://github.com/stackrox/kube-linter
ENV KUBELINTER_VERSION=0.6.8
Expand All @@ -23,7 +23,7 @@
ENV STERN_RELEASE_VERSION=1.28.0

# Use the gke-auth-plugin to authenticate to the GKE cluster.
ENV USE_GKE_GCLOUD_AUTH_PLUGIN=true

Check warning on line 26 in Dockerfile

View workflow job for this annotation

GitHub Actions / test

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ENV "USE_GKE_GCLOUD_AUTH_PLUGIN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

RUN apk add --no-cache py-pip python3-dev curl make mysql-client mariadb-connector-c gettext bash openssl libffi-dev openssl-dev gcc libc-dev jq yq rust cargo bat rsync yamllint util-linux && \
# Install docker and docker-compose.
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# make cli
#
DOCKER_VERSION=20.10.5
GOOGLE_CLOUD_CLI_IMAGE_TAG ?= 489.0.0-alpine
GOOGLE_CLOUD_CLI_IMAGE_TAG ?= 504.0.0-alpine

cli: build-docker-image
# Run the cli.
Expand Down
Loading