DUI3-326: Add civil3d 2024 converter #3548
Conversation
|
|
||
| namespace Speckle.Connectors.Autocad.DependencyInjection; | ||
|
|
||
| public static class SharedRegistration |
There was a problem hiding this comment.
Why this class need to be static?
There was a problem hiding this comment.
registration is usually static and local to the module
| @@ -5,7 +5,7 @@ | |||
| using Speckle.Converters.Common; | |||
| using Speckle.Converters.Common.DependencyInjection; | |||
|
|
|||
| namespace Speckle.Converters.Autocad20243.DependencyInjection; | |||
| namespace Speckle.Converters.Autocad2024.DependencyInjection; | |||
There was a problem hiding this comment.
Do we have anything related autocad 2024 yet?
There was a problem hiding this comment.
I think it's a tester for when we do.
There was a problem hiding this comment.
Yes the autocad 2024 converter is required for civil3d 2024
|
|
||
| namespace Speckle.Converters.Autocad.ToSpeckle.Raw; | ||
|
|
||
| public class DBCurveToSpeckleRawConverter : ITypedConverter<ADB.Curve, Objects.ICurve>, ITypedConverter<ADB.Curve, Base> |
There was a problem hiding this comment.
What is the behavior if we inherit 2 different interface?
There was a problem hiding this comment.
shouldn't be any different than just 1
There is no difference between having a converter implement both |
Adds the Civil3d 2024 converter.
This pr includes required changes to container registration in order to support converter injection into a connector vertical.
These changes should be reflected in the other DUI3 converter DI projects before this pr is merged.
First pipe sent to speckle from Civil3d: https://app.speckle.systems/projects/b53a53697a/models/719612f9da
Description & motivation
Changes:
To-do before merge: