Add some missing bits

- rake gem:release does too much
- fix rake gem:install task
- rake git:tag:create needs VERSION
- no need to use sudo

.github/workflows/release.yml

@@ -25,8 +25,8 @@ jobs:
 
       - uses: rubygems/configure-rubygems-credentials@v1.0.0
 
-      # build gem
-      - run: bundle exec rake gem:release
+      # ensure gem can be built and installed
+      - run: bundle exec rake gem:install
 
       # push gem to rubygems.org
       - run: gem push --verbose pkg/addressable-${VERSION}.gem

RELEASING.md

@@ -6,6 +6,6 @@
 1. Create pull request with all that
 1. Merge the pull request when CI is green
 1. Ensure you have latest changes locally
-1. Run `rake git:tag:create` to create tag in git
+1. Run`VERSION=x.y.z rake git:tag:create` to create tag in git
 1. Push tag to upstream: `git push --tags upstream`
 1. Watch GitHub Actions build and push the gem to RubyGems.org

Rakefile

@@ -34,7 +34,4 @@ PKG_FILES = FileList[
 
 task :default => "spec"
 
-WINDOWS = (RUBY_PLATFORM =~ /mswin|win32|mingw|bccwin|cygwin/) rescue false
-SUDO = WINDOWS ? '' : ('sudo' unless ENV['SUDOLESS'])
-
 Dir['tasks/**/*.rake'].each { |rake| load rake }

tasks/gem.rake

@@ -56,7 +56,7 @@ namespace :gem do
 
   desc "Install the gem"
   task :install => ["clobber", "gem:package"] do
-    sh "#{SUDO} gem install --local pkg/#{GEM_SPEC.full_name}"
+    sh "gem install --local ./pkg/#{GEM_SPEC.full_name}.gem"
   end
 
   desc "Uninstall the gem"
@@ -65,7 +65,7 @@ namespace :gem do
     if installed_list &&
         (installed_list.collect { |s| s.version.to_s}.include?(PKG_VERSION))
       sh(
-        "#{SUDO} gem uninstall --version '#{PKG_VERSION}' " +
+        "gem uninstall --version '#{PKG_VERSION}' " +
         "--ignore-dependencies --executables #{PKG_NAME}"
       )
     end