-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sqlite support #1770
Open
rudolfschmidt
wants to merge
2
commits into
spring-projects:main
Choose a base branch
from
rudolfschmidt:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add sqlite support #1770
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
...ational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
package org.springframework.data.relational.core.dialect; | ||
|
||
import org.springframework.core.convert.converter.Converter; | ||
import org.springframework.data.convert.ReadingConverter; | ||
import org.springframework.data.convert.WritingConverter; | ||
import org.springframework.data.relational.core.sql.LockOptions; | ||
|
||
import java.time.Instant; | ||
import java.time.LocalDateTime; | ||
import java.time.ZoneOffset; | ||
import java.util.ArrayList; | ||
import java.util.Collection; | ||
|
||
/** | ||
* SQL Dialect for SQLite. | ||
* | ||
* @author Rudolf Schmidt | ||
* @since 3.3.0 | ||
*/ | ||
public class SQLiteDialect extends AbstractDialect { | ||
|
||
public static final SQLiteDialect INSTANCE = new SQLiteDialect(); | ||
|
||
private static final LimitClause LIMIT_CLAUSE = new LimitClause() { | ||
@Override | ||
public String getLimit(long limit) { | ||
return String.format("limit %d", limit); | ||
} | ||
|
||
@Override | ||
public String getOffset(long offset) { | ||
throw new UnsupportedOperationException("offset alone not supported"); | ||
} | ||
|
||
@Override | ||
public String getLimitOffset(long limit, long offset) { | ||
return String.format("limit %d offset %d", limit, offset); | ||
} | ||
|
||
@Override | ||
public Position getClausePosition() { | ||
return Position.AFTER_ORDER_BY; | ||
} | ||
}; | ||
|
||
private static final LockClause LOCK_CLAUSE = new LockClause() { | ||
@Override | ||
public String getLock(LockOptions lockOptions) { | ||
return ""; | ||
} | ||
|
||
@Override | ||
public Position getClausePosition() { | ||
return Position.AFTER_ORDER_BY; | ||
} | ||
}; | ||
|
||
private SQLiteDialect() { | ||
} | ||
|
||
@Override | ||
public LimitClause limit() { | ||
return LIMIT_CLAUSE; | ||
} | ||
|
||
@Override | ||
public LockClause lock() { | ||
return LOCK_CLAUSE; | ||
} | ||
|
||
@Override | ||
public Collection<Object> getConverters() { | ||
Collection<Object> converters = new ArrayList<>(super.getConverters()); | ||
converters.add(LocalDateTimeToNumericConverter.INSTANCE); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't tried this dialect, but since sqlite, doesn't support boolean tye the same as everyone else, we should probably add a conversion for this too |
||
converters.add(NumericToLocalDateTimeConverter.INSTANCE); | ||
return converters; | ||
} | ||
|
||
@WritingConverter | ||
private enum LocalDateTimeToNumericConverter implements Converter<LocalDateTime, Long> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
INSTANCE; | ||
|
||
@Override | ||
public Long convert(LocalDateTime source) { | ||
return source.atZone(ZoneOffset.UTC).toInstant().toEpochMilli(); | ||
} | ||
} | ||
|
||
@ReadingConverter | ||
private enum NumericToLocalDateTimeConverter implements Converter<Long, LocalDateTime> { | ||
|
||
INSTANCE; | ||
|
||
@Override | ||
public LocalDateTime convert(Long source) { | ||
return Instant.ofEpochMilli(source).atZone(ZoneOffset.UTC).toLocalDateTime(); | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do better, like
LIMIT -1 OFFSET %d
. According to official documentation it is fine to setLIMIT
to the negative value.