-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Feat : Implements ConcurrentBatchCounter
#34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- YAGNI 원칙에 따른 기능 최적화 Signed-off-by: Hyeon-hak Kim <hyeonhak.kim.dev@gmail.com>
- Async/Virtual: `newVirtualThreadPerTaskExecutor` - Sync/OS: `newFixedThreadPool` - Async/OS: `newCachedThreadPool` (삭제) Signed-off-by: Hyeon-hak Kim <hyeonhak.kim.dev@gmail.com>
Signed-off-by: Hyeon-hak Kim <hyeonhak.kim.dev@gmail.com>
Signed-off-by: Hyeon-hak Kim <hyeonhak.kim.dev@gmail.com>
Signed-off-by: Hyeon-hak Kim <hyeonhak.kim.dev@gmail.com>
ooMia
changed the title
[x] ✨ Feat : Implements
✨ Feat : Implements Apr 5, 2024
ConcurrentBatchCounter
ConcurrentBatchCounter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #34 +/- ##
==============================================
- Coverage 97.77% 79.13% -18.65%
- Complexity 22 38 +16
==============================================
Files 5 9 +4
Lines 45 115 +70
Branches 1 6 +5
==============================================
+ Hits 44 91 +47
- Misses 0 22 +22
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hyeon-hak Kim <hyeonhak.kim.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
ConcurrentBatchCounter
인터페이스에 대한 구현체변경 사항
ConcurrentBatchingCounter
ConcurrentParameterizedBatchingCounter
추가 정보
ConcurrentParameterizedBatchingCounter
flush
하여 해결ConcurrentBatchingCounter
테스트
관련 이슈
Closes #33