Fix potential issue with overloads

sschr15 · Dec 18, 2024 · 238db71 · 238db71
1 parent 0d03cf4
commit 238db71
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/compiler-plugin/build.gradle.kts b/compiler-plugin/build.gradle.kts
@@ -83,7 +83,7 @@ allprojects {
 
                 name = "AoC Utility Kotlin Compiler Plugin"
                 description = "Adds some utilities to code, developed originally for Advent of Code solving"
-                url = "https://github.com/advent-of-code/"
+                url = "https://github.com/sschr15/advent-of-code/"
 
                 developers {
                     developer {

diff --git a/compiler-plugin/runtime-components/src/main/kotlin/SkipOverflowUnderflowCheck.kt b/compiler-plugin/runtime-components/src/main/kotlin/SkipOverflowUnderflowCheck.kt
@@ -1,4 +1,4 @@
-package sschr15.aoc.annotations
+package com.sschr15.aoc.annotations
 
 /**
  * Marks an expression to skip overflow and underflow checks.

diff --git a/compiler-plugin/src/main/kotlin/OverflowUnderflowChecker.kt b/compiler-plugin/src/main/kotlin/OverflowUnderflowChecker.kt
@@ -37,6 +37,10 @@ class OverflowUnderflowChecker(private val context: IrPluginContext, private val
         "rem",
     )
 
+    val singleArgumentTypeChecks = setOf(
+        "inc", "dec", "unaryMinus", "abs",
+    )
+
     val intConversions = setOf("toFloat")
     val longConversions = setOf("toInt", "toDouble", "toFloat")
     val absoluteValueName = Name.special("<get-absoluteValue>")
@@ -112,8 +116,11 @@ class OverflowUnderflowChecker(private val context: IrPluginContext, private val
         val primitiveType = expression.type.getPrimitiveType() ?: return super.visitCall(expression)
         if (primitiveType != PrimitiveType.INT && primitiveType != PrimitiveType.LONG) return super.visitCall(expression)
         if (expression.symbol.owner.name.asString() !in singleTypeChecks) return super.visitCall(expression)
-        if (expression.valueArgumentsCount == 2 && expression.getValueArgument(0)!!.type != expression.getValueArgument(1)!!.type) {
-            config.report(CompilerMessageSeverity.WARNING, "Arguments to arithmetic operations are of different types, skipping overflow check")
+        if (
+            (expression.valueArgumentsCount != 2 || expression.getValueArgument(0)!!.type != expression.getValueArgument(1)!!.type) &&
+            (expression.valueArgumentsCount != 1 || !singleArgumentTypeChecks.contains(expression.symbol.owner.name.asString()))
+        ) {
+            config.report(CompilerMessageSeverity.WARNING, "Unexpected number of arguments for ${expression.symbol.owner.name}, skipping")
             return super.visitCall(expression)
         }