Enable fail-fast for ExtendedTestSet by adding compatibility with FallbackTestSet. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktchu
changed the title
…ltTestSet) * Add unit test to cover cases when nested DefaultTestSets have no failing tests.
* This chance is made for backward compatibility with Julia 1.0
|
I have added code for backward compatibility with Julia 1.3 and Julia 1.0. Unit tests are passing, but code coverage checks are failing due to a "Error sending Email notification: Value cannot be null. Parameter name: source" error (see attached screen shot).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not support fail-fast because FallbackTestSet does not possess the same fields as DefaultTestSet. This PR adds support for fail-fast by adding compatibility with FallbackTestSet. Compatibility with FallbackTestSet is achieved by specializing the type for the original Test.record() method to ExtendedTestSet{DefaultTestSet} and adding a record(ts::ExtendedTestSet{T}, res::Fail) method that calls the record method for T.
One of the issues that arises when using FallbackTestSet is the generation of redundant error messages when test sets are nested. In this PR, this issues is addressed by suppressing output messages originating from errors generated when a test set detects that an enclosed test or test set has failed (via the introduction of a ExtendedTestSetException to distinguish between the original test failure/error and subsequent test errors).
Unit tests have been added to verify the expected fail-fast behavior.